Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NaN warning issue in request input size component #9415

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Fix NaN warning issue in request input size component #9415

merged 1 commit into from
Jul 7, 2021

Conversation

rohitkrai03
Copy link
Contributor

Fixes: https://issues.redhat.com/browse/ODC-6089

Analysis / Root cause: Request input size component was trying to parse empty string into an integer which resulted in NaN and threw warning.

Solution Description: Check for empty string or null values before attempting integer parse for the value.

Screen shots / Gifs for design review: No Change

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 6, 2021
@rohitkrai03 rohitkrai03 requested a review from spadgett July 7, 2021 07:38
@rohitkrai03
Copy link
Contributor Author

/retest

spadgett
spadgett approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a454ce0 into openshift:master Jul 7, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
@rohitkrai03 rohitkrai03 deleted the odc-6089 branch July 24, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.
3 participants
@rohitkrai03 @spadgett @openshift-merge-robot