Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2361: Remove orphaned PatternFly 3 notifications drawer, too… #9460

Merged
merged 1 commit into from Jul 15, 2021
Merged

CONSOLE-2361: Remove orphaned PatternFly 3 notifications drawer, too… #9460

merged 1 commit into from Jul 15, 2021

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Jul 9, 2021 •
edited

…lbar css

These styles were orphaned when the components were switched to the PatternFly 4 equivalents.

@rhamilto
Copy link
Member Author

rhamilto commented Jul 9, 2021

/hold for approval

/assign @yapei

@yapei We just need a regression test to make sure there are no visual problems with these changes.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2021
@openshift-ci openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 9, 2021
@XiyunZhao
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 14, 2021
@spadgett
Copy link
Member

This PR has no user visible changes, and we have general docs and px approval for this epic. @ahardin-rh @sferich888 FYI

/label docs-approved
/label px-approved
/hold cancel

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 14, 2021
spadgett
spadgett approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit 700fbb6 into openshift:master Jul 15, 2021
@rhamilto rhamilto deleted the remove-orphaned-pf3-partials branch July 15, 2021 11:53
@sg00dwin sg00dwin mentioned this pull request Jul 15, 2021
Merged
@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@sg00dwin sg00dwin Awaiting requested review from sg00dwin

Assignees

@spadgett spadgett

@sg00dwin sg00dwin

@yapei yapei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rhamilto @XiyunZhao @spadgett @sg00dwin @yapei @openshift-merge-robot