Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-2361: Remove remaining Bootstrap and Patternfly3 dependencies #9532

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Jul 15, 2021

Addition of ancillary css partials to support bootstrap and pf3 while their dependencies are removed from package.json. In conjunction with their removal we are enabling the pf4 reset and removing the shield-inheritables rules as is the recommended Patternfly default settings. These changes could cause secondary issues as the result of embedded custom rules relying upon those settings.*

Includes removal and/or changes to rules and variables that are no longer in use. Switching out PF3 color vars for PF4 corresponding vars.

Some Patternfly components have styles scoped to a primary parent rule. A primary example being .pf-c-content which assigns many html element specific variable names, eg. --pf-c-content--h2--MarginTop: var(--pf-global--spacer--lg) that set values for the child, in this case h2. And since we don’t wrap our content in the pf-c-content class then these child elements aren't passed those values.

*Lots of legacy rules built upon or intermixed within our custom plugins and components.

Related PRs

#9419
#9452
#9458
#9460
#9462
#9512
#9515
#9517
#9524
#9555
#9650

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2021
@openshift-ci openshift-ci bot requested review from rhamilto and spadgett July 15, 2021 19:38
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared labels Jul 15, 2021
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2021
@sg00dwin sg00dwin force-pushed the remove-dependencies-bootstrap-and-PF3 branch 7 times, most recently from 36af5f0 to b7c0e6e Compare July 16, 2021 22:31
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

A few comments.

And https://github.com/openshift/console/pull/9532/files#diff-049faa5ce34c5bf62e8472fcaef6a95175850c7e3949acc7480fa4b1d70dccc5L6-L8 is a problem since you're cutting the dependency but still including the color vars. Need to update anything that is using a PF3 color var to a PF4 color var.

frontend/public/components/modals/_modals.scss Outdated Show resolved Hide resolved
frontend/public/components/modals/_modals.scss Outdated Show resolved Hide resolved
frontend/public/components/modals/_modals.scss Outdated Show resolved Hide resolved
frontend/public/style/_vars.scss Outdated Show resolved Hide resolved
frontend/public/style/_vars.scss Outdated Show resolved Hide resolved
frontend/public/style/_vars.scss Outdated Show resolved Hide resolved
frontend/public/style/_vars.scss Outdated Show resolved Hide resolved
frontend/public/style/_vars.scss Outdated Show resolved Hide resolved
frontend/public/style/_vars.scss Outdated Show resolved Hide resolved
frontend/package.json Outdated Show resolved Hide resolved
frontend/public/style/_base.scss Outdated Show resolved Hide resolved
frontend/public/style/_base.scss Outdated Show resolved Hide resolved
@sg00dwin sg00dwin force-pushed the remove-dependencies-bootstrap-and-PF3 branch from b7c0e6e to 658836d Compare July 29, 2021 17:32
@openshift-ci openshift-ci bot added component/monitoring Related to monitoring component/olm Related to OLM component/topology Related to topology and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 29, 2021
@sg00dwin sg00dwin force-pushed the remove-dependencies-bootstrap-and-PF3 branch from 658836d to eabb461 Compare July 29, 2021 17:40
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, @sg00dwin. A few nits.

frontend/public/style.scss Outdated Show resolved Hide resolved
frontend/public/style/ancillary/_bootstrap.scss Outdated Show resolved Hide resolved
frontend/public/style/ancillary/_bootstrap-utilities.scss Outdated Show resolved Hide resolved
@rhamilto
Copy link
Member

/assign @yapei
for QE approval. @yapei this is a pretty significant change to our CSS, and I imagine it is going to result in some regressions (despite heroic efforts by @sg00dwin to address any issues). Unless there is something significant, I think it is in our best interests to merge this sooner rather than later so we have more time for any possible regressions to be identified and fixed prior to release.

This PR has no user visible changes, and we have general docs and px approval for this epic. @ahardin-rh @sferich888 FYI

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jul 29, 2021
@XiyunZhao
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 30, 2021
@XiyunZhao
Copy link

This change is verified on the private build.
No issue found on Overview, events, Resource Quotas, ImageStreams, and so on pages. The changes for the component layout, color, view and etc. are not impacting the normal view or function of the page. like form, nav-action, error_msg and so on

… their dependencies are removed from package.json. In conjunction with their removal we are enabling the pf4 reset and removing the shield-inheritables rules. Also additional changes to rules and variables no longer in use.
@sg00dwin sg00dwin force-pushed the remove-dependencies-bootstrap-and-PF3 branch from eabb461 to 5ed38f8 Compare August 4, 2021 17:17
@sg00dwin sg00dwin changed the title [WIP] CONSOLE-2361: Remove remaining Bootstrap and Patternfly3 dependencies CONSOLE-2361: Remove remaining Bootstrap and Patternfly3 dependencies Aug 4, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2021
@sg00dwin
Copy link
Member Author

sg00dwin commented Aug 4, 2021

/retest

@rhamilto
Copy link
Member

rhamilto commented Aug 5, 2021

/lgtm

@rhamilto
Copy link
Member

rhamilto commented Aug 5, 2021

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2021
@spadgett
Copy link
Member

spadgett commented Aug 5, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit 75b5bce into openshift:master Aug 6, 2021
@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
@sg00dwin sg00dwin deleted the remove-dependencies-bootstrap-and-PF3 branch January 26, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/monitoring Related to monitoring component/olm Related to OLM component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants