New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2361: Remove remaining Bootstrap and Patternfly3 dependencies #9532
CONSOLE-2361: Remove remaining Bootstrap and Patternfly3 dependencies #9532
Conversation
36af5f0
to
b7c0e6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
A few comments.
And https://github.com/openshift/console/pull/9532/files#diff-049faa5ce34c5bf62e8472fcaef6a95175850c7e3949acc7480fa4b1d70dccc5L6-L8 is a problem since you're cutting the dependency but still including the color vars. Need to update anything that is using a PF3 color var to a PF4 color var.
b7c0e6e
to
658836d
Compare
658836d
to
eabb461
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, @sg00dwin. A few nits.
/assign @yapei This PR has no user visible changes, and we have general docs and px approval for this epic. @ahardin-rh @sferich888 FYI /label docs-approved |
/label qe-approved |
This change is verified on the private build. |
… their dependencies are removed from package.json. In conjunction with their removal we are enabling the pf4 reset and removing the shield-inheritables rules. Also additional changes to rules and variables no longer in use.
eabb461
to
5ed38f8
Compare
/retest |
/lgtm |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, sg00dwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Addition of ancillary css partials to support bootstrap and pf3 while their dependencies are removed from package.json. In conjunction with their removal we are enabling the pf4 reset and removing the shield-inheritables rules as is the recommended Patternfly default settings. These changes could cause secondary issues as the result of embedded custom rules relying upon those settings.*
Includes removal and/or changes to rules and variables that are no longer in use. Switching out PF3 color vars for PF4 corresponding vars.
Some Patternfly components have styles scoped to a primary parent rule. A primary example being
.pf-c-content
which assigns many html element specific variable names, eg.--pf-c-content--h2--MarginTop: var(--pf-global--spacer--lg)
that set values for the child, in this caseh2
. And since we don’t wrap our content in thepf-c-content
class then these child elements aren't passed those values.*Lots of legacy rules built upon or intermixed within our custom plugins and components.
Related PRs
#9419
#9452
#9458
#9460
#9462
#9512
#9515
#9517
#9524
#9555
#9650