New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1981417: Change OCM links from cloud. to console.redhat.com #9469
Conversation
Due to the last announcement of migration of all cloud.redhat.com located services to console.redhat.com, we need to make sure we are not pointing to the deprecated websites.
@gkarat: This pull request references Bugzilla bug 1981417, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@spadgett, could you please take a look? 🙏🏼 🐤 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gkarat We should look at updating all of the links to cloud.redhat.com
in console:
❯ rg -F 'cloud.redhat.com' -tjs -tts
frontend/packages/rhoas-plugin/src/components/access-services/ServicesToken.tsx
55: href="https://cloud.redhat.com/openshift/token"
59: https://cloud.redhat.com
frontend/packages/rhoas-plugin/src/components/service-list/ServiceInstance.tsx
58: <a href="https://cloud.redhat.com/openshift/token" rel="noopener noreferrer" target="_blank">
59: https://cloud.redhat.com.
frontend/public/module/k8s/cluster-settings.ts
250: `https://cloud.redhat.com/openshift/details/${clusterID}`;
frontend/packages/insights-plugin/src/components/InsightsPopup/index.tsx
110: href={`https://cloud.redhat.com/openshift/details/${clusterID}#insights`}
119: href={`https://cloud.redhat.com/openshift/`}
frontend/packages/knative-plugin/src/utils/__tests__/knative-serving-data.ts
683: 'https://cloud.redhat.com/beta/application-services/openshift-streams/kafkas/1qCXzgiGqva0D5bXIB0Gn9g23Ni',
@spadgett, I have edited the links you have mentioned in your comment. But I am afraid I pretty easily can break some of the components. Instead, I believe it is up to the responsible teams to take care of their integrations and packages. I just don't have enough domain knowledge outside the CCX integration (Insights Advisor), unfortunately. Can we raise that issue on the platform channels? I believe people should be aware of the c.r.c. changes and act accordingly. |
@andrewballantyne @christianvogt Can you help review or verify the changes to rhoas-plugin and knative-plugin? Changes to cluster-settings.ts lgtm |
@gkarat Looks like you need to run |
changes lgtm |
Due to the last announcement of migration of all cloud.redhat.com located services to console.redhat.com, we need to make sure we are not pointing to the deprecated websites.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot @gkarat
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gkarat, spadgett, tisnik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 1981417, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 1981417, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@gkarat: This pull request references Bugzilla bug 1981417, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dmisharo@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gkarat: All pull requests linked via external trackers have merged: Bugzilla bug 1981417 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes https://issues.redhat.com/browse/CCXDEV-5149.
Due to the last announcement of migration of all cloud.redhat.com located services to console.redhat.com, we need to make sure we are not pointing to the deprecated websites.