Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1981417: Change OCM links from cloud. to console.redhat.com #9469

Merged
merged 2 commits into from Jul 19, 2021

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Jul 12, 2021

Fixes https://issues.redhat.com/browse/CCXDEV-5149.

Due to the last announcement of migration of all cloud.redhat.com located services to console.redhat.com, we need to make sure we are not pointing to the deprecated websites.

Due to the last announcement of migration of all cloud.redhat.com
located services to console.redhat.com, we need to make sure we are
not pointing to the deprecated websites.
@openshift-ci openshift-ci bot requested review from jhadvig and tisnik July 12, 2021 13:42
@openshift-ci openshift-ci bot added component/insights Related to insights plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 12, 2021
@gkarat gkarat changed the title Change OCM links from cloud. to console.redhat.com Bug 1981417: Change OCM links from cloud. to console.redhat.com Jul 12, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2021

@gkarat: This pull request references Bugzilla bug 1981417, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1981417: Change OCM links from cloud. to console.redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gkarat
Copy link
Contributor Author

gkarat commented Jul 12, 2021

@spadgett, could you please take a look? 🙏🏼 🐤

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkarat We should look at updating all of the links to cloud.redhat.com in console:

❯ rg -F 'cloud.redhat.com' -tjs -tts
frontend/packages/rhoas-plugin/src/components/access-services/ServicesToken.tsx
55:              href="https://cloud.redhat.com/openshift/token"
59:              https://cloud.redhat.com

frontend/packages/rhoas-plugin/src/components/service-list/ServiceInstance.tsx
58:      <a href="https://cloud.redhat.com/openshift/token" rel="noopener noreferrer" target="_blank">
59:        https://cloud.redhat.com.

frontend/public/module/k8s/cluster-settings.ts
250:  `https://cloud.redhat.com/openshift/details/${clusterID}`;

frontend/packages/insights-plugin/src/components/InsightsPopup/index.tsx
110:                href={`https://cloud.redhat.com/openshift/details/${clusterID}#insights`}
119:              href={`https://cloud.redhat.com/openshift/`}

frontend/packages/knative-plugin/src/utils/__tests__/knative-serving-data.ts
683:          'https://cloud.redhat.com/beta/application-services/openshift-streams/kafkas/1qCXzgiGqva0D5bXIB0Gn9g23Ni',

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/knative Related to knative-plugin and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 14, 2021
@gkarat
Copy link
Contributor Author

gkarat commented Jul 14, 2021

@spadgett, I have edited the links you have mentioned in your comment. But I am afraid I pretty easily can break some of the components. Instead, I believe it is up to the responsible teams to take care of their integrations and packages. I just don't have enough domain knowledge outside the CCX integration (Insights Advisor), unfortunately.

Can we raise that issue on the platform channels? I believe people should be aware of the c.r.c. changes and act accordingly.

@spadgett
Copy link
Member

@spadgett, I have edited the links you have mentioned in your comment. But I am afraid I pretty easily can break some of the components. Instead, I believe it is up to the responsible teams to take care of their integrations and packages. I just don't have enough domain knowledge outside the CCX integration (Insights Advisor), unfortunately.

Can we raise that issue on the platform channels? I believe people should be aware of the c.r.c. changes and act accordingly.

@andrewballantyne @christianvogt Can you help review or verify the changes to rhoas-plugin and knative-plugin?

Changes to cluster-settings.ts lgtm

@spadgett
Copy link
Member

@gkarat Looks like you need to run yarn i18n

@christianvogt
Copy link
Contributor

changes lgtm

Due to the last announcement of migration of all cloud.redhat.com located services to console.redhat.com,
we need to make sure we are not pointing to the deprecated websites.
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jul 15, 2021
@gkarat gkarat requested a review from spadgett July 15, 2021 07:49
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 15, 2021
Copy link

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @gkarat

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gkarat, spadgett, tisnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2021

@openshift-bot: This pull request references Bugzilla bug 1981417, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

@openshift-bot: This pull request references Bugzilla bug 1981417, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gkarat
Copy link
Contributor Author

gkarat commented Jul 19, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

@gkarat: This pull request references Bugzilla bug 1981417, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dmisharo@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 8a56f9e into openshift:master Jul 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

@gkarat: All pull requests linked via external trackers have merged:

Bugzilla bug 1981417 has been moved to the MODIFIED state.

In response to this:

Bug 1981417: Change OCM links from cloud. to console.redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/insights Related to insights plugin component/knative Related to knative-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants