Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(4.8 Backport) Bug 1981416: Change OCM links from cloud. to console.redhat.com #9470

Merged
merged 1 commit into from Oct 14, 2021

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Jul 12, 2021

Fixes https://issues.redhat.com/browse/CCXDEV-5149.

Due to the last announcement of migration of all cloud.redhat.com located services to console.redhat.com, we need to make sure we are not pointing to the deprecated websites.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2021

@gkarat: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Change OCM links from cloud. to console.redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from spadgett and tisnik July 12, 2021 13:48
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2021
@gkarat gkarat changed the title Change OCM links from cloud. to console.redhat.com (4.8 Backport) Change OCM links from cloud. to console.redhat.com Jul 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2021

@gkarat: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

(4.8 Backport) Change OCM links from cloud. to console.redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gkarat gkarat changed the title (4.8 Backport) Change OCM links from cloud. to console.redhat.com (4.8 Backport) Bug 1981416: Change OCM links from cloud. to console.redhat.com Jul 12, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2021

@gkarat: This pull request references Bugzilla bug 1981416, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1981416 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

(4.8 Backport) Bug 1981416: Change OCM links from cloud. to console.redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gkarat
Copy link
Contributor Author

gkarat commented Jul 12, 2021

@spadgett, PTAL 🦝

@gkarat
Copy link
Contributor Author

gkarat commented Jul 15, 2021

Updated the links from the @spadgett comment #9469 (review) here too.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/knative Related to knative-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 15, 2021
Copy link

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkarat
Copy link
Contributor Author

gkarat commented Jul 19, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

@gkarat: This pull request references Bugzilla bug 1981416, which is invalid:

  • expected Bugzilla bug 1981416 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gkarat
Copy link
Contributor Author

gkarat commented Jul 19, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

@gkarat: This pull request references Bugzilla bug 1981416, which is invalid:

  • expected dependent Bugzilla bug 1981417 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gkarat
Copy link
Contributor Author

gkarat commented Jul 19, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

@gkarat: This pull request references Bugzilla bug 1981416, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1981417 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1981417 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dmisharo@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 19, 2021
Fixes https://issues.redhat.com/browse/CCXDEV-5149.

Due to the last announcement of migration of all cloud.redhat.com located services to console.redhat.com, we need to make sure we are not pointing to the deprecated websites.
@gkarat
Copy link
Contributor Author

gkarat commented Oct 11, 2021

There was a merge conflict, fixed in the last force push (rewritten the existing commit)

@gkarat
Copy link
Contributor Author

gkarat commented Oct 11, 2021

Ready for review @spadgett

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gkarat, spadgett, tisnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@spadgett
Copy link
Member

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2021

@spadgett: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 12, 2021
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit 55b4734 into openshift:release-4.8 Oct 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2021

@gkarat: All pull requests linked via external trackers have merged:

Bugzilla bug 1981416 has been moved to the MODIFIED state.

In response to this:

(4.8 Backport) Bug 1981416: Change OCM links from cloud. to console.redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot added a commit that referenced this pull request Oct 15, 2021
(4.7 Backport) Bug 1981412: Change OCM links from cloud. to console.redhat.com #9470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality component/insights Related to insights plugin component/knative Related to knative-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants