Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2361: Replace Bootstrap float utility class with PF equivalent #9517

Merged
merged 1 commit into from Jul 19, 2021
Merged

CONSOLE-2361: Replace Bootstrap float utility class with PF equivalent #9517

merged 1 commit into from Jul 19, 2021

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Jul 14, 2021 •
edited

Format for "Try It" "Download YAML" buttons.

Screen Shot 2021-07-15 at 3 32 38 PM

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Jul 14, 2021
@rhamilto
Copy link
Member

Wondering if we can't maintain the layout here without adding a new partial just to float two items?

@rhamilto
Copy link
Member

Wondering if we can't maintain the layout here without adding a new partial just to float two items?

Seems like https://www.patternfly.org/v4/layouts/level would give us what we want here.

@sg00dwin sg00dwin force-pushed the replace-bootstrap-utility-pull-with-PF-equivalent branch from f35e670 to 304b8d9 Compare July 15, 2021 18:02
@sg00dwin
Copy link
Member Author

Switched to use Level component.

@rhamilto
Copy link
Member

Code changes look good. Maybe some screenshots to help QE verify?

@sg00dwin sg00dwin mentioned this pull request Jul 15, 2021
Merged
@XiyunZhao
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 16, 2021
@XiyunZhao
Copy link

This PR is verified on private build and did not find any issue, the layout and view of ''Download YAML" button is not being impacted on this changes

rhamilto
rhamilto reviewed Jul 16, 2021
View reviewed changes
frontend/public/components/sidebars/resource-sidebar-samples.tsx Outdated
<LevelItem>
<Button
type="button"
className="pf-u-float-right"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Looks like this was forgotten.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yanked it

@sg00dwin sg00dwin force-pushed the replace-bootstrap-utility-pull-with-PF-equivalent branch from 304b8d9 to 969409b Compare July 16, 2021 20:33
rhamilto
rhamilto approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2021
@sg00dwin
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 01ae555 into openshift:master Jul 19, 2021
@sg00dwin sg00dwin deleted the replace-bootstrap-utility-pull-with-PF-equivalent branch July 20, 2021 19:30
@spadgett spadgett added this to the v4.9 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sg00dwin @rhamilto @XiyunZhao @spadgett @openshift-merge-robot