Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-6128
Analysis / Root cause:
Bisect the missing form footer, it was now shown anymore after #9329 was merged. But this change doesn't include an obvious reason why this breaks.
Solution Description:
Other shadows was added via a scss variable instead of the PF utility classname. So change this to similar implementation.
Search for
pf-u-box-shadow
vs--pf-global--BoxShadow
Screen shots / Gifs for design review:
Before:
After:
Unit test coverage report:
Unchanged
Test setup:
Browser conformance: