Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug 1985193: Add create resource extension #9601

Merged
merged 2 commits into from Aug 12, 2021
Merged

[release-4.8] Bug 1985193: Add create resource extension #9601

merged 2 commits into from Aug 12, 2021

Conversation

rawagner
Copy link
Contributor

cherry-pick of #9395

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jul 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

@rawagner: This pull request references Bugzilla bug 1985193, which is invalid:

  • expected dependent Bugzilla bug 1973565 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] Bug 1985193: Add create resource extension

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 23, 2021
@openshift-ci openshift-ci bot requested review from afreen23 and shyRozen July 23, 2021 07:45
@openshift-ci openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. component/lso Related to local-storage-operator-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Jul 23, 2021
@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

@openshift-bot: This pull request references Bugzilla bug 1985193, which is invalid:

  • expected dependent Bugzilla bug 1973565 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2021

@openshift-bot: This pull request references Bugzilla bug 1985193, which is invalid:

  • expected dependent Bugzilla bug 1973565 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rawagner
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2021

@rawagner: This pull request references Bugzilla bug 1985193, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1973565 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1973565 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei July 30, 2021 15:50
@spadgett
Copy link
Member

spadgett commented Aug 3, 2021

/hold

We are investigating a possible regression in the create operand form.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2021
@ecordell
Copy link
Contributor

ecordell commented Aug 4, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.00
  • Reason: skipping because "do-not-merge/hold" label found

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@yanpzhan
Copy link
Contributor

yanpzhan commented Aug 5, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

@yanpzhan: This pull request references Bugzilla bug 1985193, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1973565 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1973565 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @yanpzhan

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yanpzhan August 5, 2021 05:33
@ecordell
Copy link
Contributor

ecordell commented Aug 5, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.00
  • Reason: skipping because "do-not-merge/hold" label found

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

3 similar comments
@ecordell
Copy link
Contributor

ecordell commented Aug 5, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.00
  • Reason: skipping because "do-not-merge/hold" label found

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@ecordell
Copy link
Contributor

ecordell commented Aug 6, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.00
  • Reason: skipping because "do-not-merge/hold" label found

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@ecordell
Copy link
Contributor

ecordell commented Aug 6, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.00
  • Reason: skipping because "do-not-merge/hold" label found

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@yanpzhan
Copy link
Contributor

yanpzhan commented Aug 9, 2021

Tested against the pr, component from dynamic plugin could be rendered instead of the static plugin. Fix for bug 1985193 works.

@christianvogt
Copy link
Contributor

@spadgett could you provide an update regarding your hold.

@rawagner
Copy link
Contributor Author

rawagner commented Aug 9, 2021

The bug is fixed in master #9711
once this PR is merged, I will backport 9711 or I can include the commit into this PR

@spadgett
Copy link
Member

/hold cancel

We can backport that separately. Thanks @rawagner

@spadgett spadgett removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2021
@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 11, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit b09905f into openshift:release-4.8 Aug 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

@rawagner: All pull requests linked via external trackers have merged:

Bugzilla bug 1985193 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 1985193: Add create resource extension

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.8.z milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afreen23 afreen23 Awaiting requested review from afreen23

@shyRozen shyRozen Awaiting requested review from shyRozen

@yapei yapei Awaiting requested review from yapei

@yanpzhan yanpzhan Awaiting requested review from yanpzhan

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/lso Related to local-storage-operator-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8.z
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rawagner @christianvogt @openshift-bot @spadgett @ecordell @yanpzhan @bparees