Bug 1989889: Render 404 create page if CRD model is missing #9711

rawagner · 2021-08-03T13:59:55Z

<= 4.8 handled the case in the same way https://github.com/openshift/console/blob/release-4.8/frontend/packages/operator-lifecycle-manager/src/components/operand/create-operand.tsx#L186

spadgett · 2021-08-03T14:24:29Z

@rawagner I realize this is how it behaved before, but it might be better to show a message like we do for the operand list:

https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/src/components/operand/index.tsx#L432-L442

rawagner · 2021-08-03T14:40:04Z

thats much better :) Updated

invincibleJai

Thanks verified the changes, user is shown with 404 if the model doesn't exist 👍

invincibleJai · 2021-08-03T16:10:30Z

frontend/packages/operator-lifecycle-manager/src/components/operand/index.spec.tsx

-      verbs: ['create'],
-    },
+  useK8sModel: (groupVersionKind) => [
+    groupVersionKind === readonlyModel.kind ? readonlyModel : testModel,


frontend tests are complaining Invalid variable access: readonlyModel

rawagner · 2021-08-04T08:06:10Z

/retest

openshift-ci · 2021-08-04T09:49:53Z

@rawagner: This pull request references Bugzilla bug 1989889, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1989889: Render 404 create page if CRD model is missing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rawagner · 2021-08-04T09:50:19Z

/bugzilla refresh

openshift-ci · 2021-08-04T09:50:26Z

@rawagner: This pull request references Bugzilla bug 1989889, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

invincibleJai · 2021-08-04T16:26:00Z

/lgtm

openshift-ci · 2021-08-04T16:26:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [invincibleJai,rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-08-04T23:25:34Z

@rawagner: All pull requests linked via external trackers have merged:

openshift/console#9711

Bugzilla bug 1989889 has been moved to the MODIFIED state.

In response to this:

Bug 1989889: Render 404 create page if CRD model is missing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett · 2021-08-10T16:30:56Z

/cherry-pick release-4.8

openshift-cherrypick-robot · 2021-08-10T16:38:33Z

@spadgett: #9711 failed to apply on top of branch "release-4.8":

Applying: Render 404 create page if CRD model is missing
Using index info to reconstruct a base tree...
M	frontend/packages/operator-lifecycle-manager/locales/en/olm.json
M	frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx
M	frontend/packages/operator-lifecycle-manager/src/components/operand/create-operand.tsx
M	frontend/packages/operator-lifecycle-manager/src/components/operand/index.spec.tsx
M	frontend/packages/operator-lifecycle-manager/src/components/operand/index.tsx
M	frontend/public/components/utils/horizontal-nav.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/utils/horizontal-nav.tsx
Auto-merging frontend/packages/operator-lifecycle-manager/src/components/operand/index.tsx
CONFLICT (content): Merge conflict in frontend/packages/operator-lifecycle-manager/src/components/operand/index.tsx
Auto-merging frontend/packages/operator-lifecycle-manager/src/components/operand/index.spec.tsx
Auto-merging frontend/packages/operator-lifecycle-manager/src/components/operand/create-operand.tsx
CONFLICT (content): Merge conflict in frontend/packages/operator-lifecycle-manager/src/components/operand/create-operand.tsx
Auto-merging frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx
CONFLICT (content): Merge conflict in frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx
Auto-merging frontend/packages/operator-lifecycle-manager/locales/en/olm.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Render 404 create page if CRD model is missing
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rawagner · 2021-08-17T16:06:58Z

/cherry-pick release-4.8

openshift-cherrypick-robot · 2021-08-17T16:08:02Z

@rawagner: #9711 failed to apply on top of branch "release-4.8":

Applying: Render 404 create page if CRD model is missing
Using index info to reconstruct a base tree...
M	frontend/packages/operator-lifecycle-manager/locales/en/olm.json
M	frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx
M	frontend/packages/operator-lifecycle-manager/src/components/operand/create-operand.tsx
M	frontend/packages/operator-lifecycle-manager/src/components/operand/index.spec.tsx
M	frontend/packages/operator-lifecycle-manager/src/components/operand/index.tsx
M	frontend/public/components/utils/horizontal-nav.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/utils/horizontal-nav.tsx
Auto-merging frontend/packages/operator-lifecycle-manager/src/components/operand/index.tsx
CONFLICT (content): Merge conflict in frontend/packages/operator-lifecycle-manager/src/components/operand/index.tsx
Auto-merging frontend/packages/operator-lifecycle-manager/src/components/operand/index.spec.tsx
Auto-merging frontend/packages/operator-lifecycle-manager/src/components/operand/create-operand.tsx
Auto-merging frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx
CONFLICT (content): Merge conflict in frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx
Auto-merging frontend/packages/operator-lifecycle-manager/locales/en/olm.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Render 404 create page if CRD model is missing
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from spadgett and TheRealJon August 3, 2021 14:00

openshift-ci bot added component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 3, 2021

rawagner force-pushed the missing_model branch from 0fe1bac to e686b48 Compare August 3, 2021 14:39

rawagner force-pushed the missing_model branch from e686b48 to 4ac8727 Compare August 3, 2021 15:00

openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Aug 3, 2021

rawagner force-pushed the missing_model branch from 4ac8727 to 2198228 Compare August 3, 2021 15:25

openshift-ci bot added the component/core Related to console core functionality label Aug 3, 2021

invincibleJai approved these changes Aug 3, 2021

View reviewed changes

invincibleJai reviewed Aug 3, 2021

View reviewed changes

rawagner force-pushed the missing_model branch 3 times, most recently from cf003d3 to 1279e49 Compare August 4, 2021 06:59

rawagner changed the title ~~Do not render create page if CRD model is missing~~ Render 404 create page if CRD model is missing Aug 4, 2021

Render 404 create page if CRD model is missing

2b9cce2

rawagner force-pushed the missing_model branch from 1279e49 to 2b9cce2 Compare August 4, 2021 08:06

rawagner changed the title ~~Render 404 create page if CRD model is missing~~ Bug 1989889: Render 404 create page if CRD model is missing Aug 4, 2021

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 4, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 4, 2021

openshift-ci bot requested a review from yapei August 4, 2021 09:50

openshift-ci bot assigned invincibleJai Aug 4, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021

openshift-ci bot merged commit 1a15311 into openshift:master Aug 4, 2021

rawagner mentioned this pull request Aug 9, 2021

[release-4.8] Bug 1985193: Add create resource extension #9601

Merged

spadgett added this to the v4.9 milestone Aug 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1989889: Render 404 create page if CRD model is missing #9711

Bug 1989889: Render 404 create page if CRD model is missing #9711

rawagner commented Aug 3, 2021

spadgett commented Aug 3, 2021

rawagner commented Aug 3, 2021

invincibleJai left a comment •

edited

invincibleJai Aug 3, 2021

rawagner commented Aug 4, 2021

openshift-ci bot commented Aug 4, 2021

rawagner commented Aug 4, 2021

openshift-ci bot commented Aug 4, 2021

invincibleJai commented Aug 4, 2021

openshift-ci bot commented Aug 4, 2021

openshift-ci bot commented Aug 4, 2021

spadgett commented Aug 10, 2021

openshift-cherrypick-robot commented Aug 10, 2021

rawagner commented Aug 17, 2021

openshift-cherrypick-robot commented Aug 17, 2021

Bug 1989889: Render 404 create page if CRD model is missing #9711

Bug 1989889: Render 404 create page if CRD model is missing #9711

Conversation

rawagner commented Aug 3, 2021

spadgett commented Aug 3, 2021

rawagner commented Aug 3, 2021

invincibleJai left a comment • edited

Choose a reason for hiding this comment

invincibleJai Aug 3, 2021

Choose a reason for hiding this comment

rawagner commented Aug 4, 2021

openshift-ci bot commented Aug 4, 2021

rawagner commented Aug 4, 2021

openshift-ci bot commented Aug 4, 2021

invincibleJai commented Aug 4, 2021

openshift-ci bot commented Aug 4, 2021

openshift-ci bot commented Aug 4, 2021

spadgett commented Aug 10, 2021

openshift-cherrypick-robot commented Aug 10, 2021

rawagner commented Aug 17, 2021

openshift-cherrypick-robot commented Aug 17, 2021

invincibleJai left a comment •

edited