Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1985161: Fix translation of incorrect addSecretDescription string within modal #9645

Merged
merged 1 commit into from Aug 4, 2021
Merged

Bug 1985161: Fix translation of incorrect addSecretDescription string within modal #9645

merged 1 commit into from Aug 4, 2021

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Jul 27, 2021 •
edited

Fix https://bugzilla.redhat.com/show_bug.cgi?id=1985161

Add all values from <1></1>{{secretName}} to a workload as environment variables or a volume.": "Add all values from <1></1>{{secretName}} to a workload as environment variables or a volume.

JA and ZH currently not translated
https://github.com/openshift/console/blob/master/frontend/public/locales/ja/public.json#L651
https://github.com/openshift/console/blob/master/frontend/public/locales/zh/public.json#L651
KO translated the string addSecretDescription 설명에 시크릿 추가
https://github.com/openshift/console/blob/master/frontend/public/locales/ko/public.json#L651

@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 27, 2021
@sg00dwin sg00dwin changed the title Fix translation of incorrect addSecretDescription string within modal Bug 1985161: Fix translation of incorrect addSecretDescription string within modal Jul 27, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2021

@sg00dwin: This pull request references Bugzilla bug 1985161, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1985161: Fix translation of incorrect addSecretDescription string within modal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei July 27, 2021 17:48
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2021

@sg00dwin: This pull request references Bugzilla bug 1985161, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1985161: Fix translation of incorrect addSecretDescription string within modal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

2 similar comments
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2021

@sg00dwin: This pull request references Bugzilla bug 1985161, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1985161: Fix translation of incorrect addSecretDescription string within modal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2021

@sg00dwin: This pull request references Bugzilla bug 1985161, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1985161: Fix translation of incorrect addSecretDescription string within modal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rebeccaalpert
rebeccaalpert approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks.

We should be able to get translations done for this one as part of the next file exchange. There may be some missing Korean translations for new stuff until the Globalization team's Korean translator has more cycles.

@rebeccaalpert rebeccaalpert added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2021
spadgett
spadgett reviewed Jul 28, 2021
View reviewed changes
frontend/public/locales/en/public.json
@@ -656,7 +656,7 @@
"Help menu": "Help menu",
"Select a workload": "Select a workload",
"Add secret to workload": "Add secret to workload",
"addSecretDescription": "Add all values from <1></1>{{secretName}} to a workload as environment variables or a volume.",
"Add all values from <1></1>{{secretName}} to a workload as environment variables or a volume.": "Add all values from <1></1>{{secretName}} to a workload as environment variables or a volume.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a space between the icon and the secret name or is that handled by CSS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resource icon has right margin for spacing. https://github.com/openshift/console/blob/master/frontend/public/components/_resource.scss#L9

@rhamilto
Copy link
Member

rhamilto commented Aug 3, 2021

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021
@rhamilto
Copy link
Member

rhamilto commented Aug 3, 2021

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@rhamilto
Copy link
Member

rhamilto commented Aug 4, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit 3876fd2 into openshift:master Aug 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2021

@sg00dwin: All pull requests linked via external trackers have merged:

Bugzilla bug 1985161 has been moved to the MODIFIED state.

In response to this:

Bug 1985161: Fix translation of incorrect addSecretDescription string within modal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sg00dwin sg00dwin deleted the i18n-bug1985161-addtosecret branch August 17, 2021 14:23
@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett left review comments

@rebeccaalpert rebeccaalpert rebeccaalpert approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@jhadvig jhadvig Awaiting requested review from jhadvig

@yapei yapei Awaiting requested review from yapei

Assignees

@rhamilto rhamilto

@rebeccaalpert rebeccaalpert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sg00dwin @rhamilto @openshift-bot @spadgett @rebeccaalpert