Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1985161: Fix translation of incorrect addSecretDescription string within modal #9645

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Bug 1985161: Fix translation of incorrect addSecretDescription string within modal #9645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/public/components/modals/add-secret-to-workload.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ export class AddSecretToWorkloadModalWithTrans extends React.Component<
<ModalTitle>{t('public~Add secret to workload')}</ModalTitle>
<ModalBody>
<p>
<Trans i18nKey="public~addSecretDescription">
<Trans t={t} ns="public">
Add all values from <ResourceIcon kind="Secret" />
{{ secretName }} to a workload as environment variables or a volume.
</Trans>
Expand Down
2 changes: 1 addition & 1 deletion frontend/public/locales/en/public.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@
"Help menu": "Help menu",
"Select a workload": "Select a workload",
"Add secret to workload": "Add secret to workload",
"addSecretDescription": "Add all values from <1></1>{{secretName}} to a workload as environment variables or a volume.",
"Add all values from <1></1>{{secretName}} to a workload as environment variables or a volume.": "Add all values from <1></1>{{secretName}} to a workload as environment variables or a volume.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a space between the icon and the secret name or is that handled by CSS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resource icon has right margin for spacing. https://github.com/openshift/console/blob/master/frontend/public/components/_resource.scss#L9

"Add this secret to workload": "Add this secret to workload",
"Add secret as": "Add secret as",
"Prefix": "Prefix",
Expand Down