Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1980531: Remove check for two sections in help menu #9702

Merged

Conversation

kdoberst
Copy link
Contributor

@kdoberst kdoberst commented Aug 2, 2021

This relates to Bug 1980531. It is the first of 3 PRs.

This first PR temporarily removes a test so the tests don't fail when the help links are removed from the operator.

This PR is required for openshift/console-operator#565 which removes the help links from the operator to pass so that PR can be merged in.

After the first two PRs are approved then #9495 #9811 can be merged which will add the help links back.

This will be added back in a future pull request when help items are removed from the console-operator and added in the console itself.
@openshift-ci openshift-ci bot added kind/cypress Related to Cypress e2e integration testing approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 2, 2021
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kdoberst, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kdoberst kdoberst changed the title Remove check for two sections in help menu Bug 1980531: Remove check for two sections in help menu Aug 3, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Aug 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

@kdoberst: This pull request references Bugzilla bug 1980531, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1980531: Remove check for two sections in help menu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 3, 2021
@openshift-ci openshift-ci bot requested a review from yapei August 3, 2021 14:51
@openshift-ci openshift-ci bot merged commit cc606c3 into openshift:master Aug 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2021

@kdoberst: An error was encountered searching for external tracker bugs for bug 1980531 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. could not parse external identifier "openshift/console/pull/9385#pullrequestreview-702386658" as pull: invalid pull identifier: could not parse 9385#pullrequestreview-702386658 as number: strconv.Atoi: parsing "9385#pullrequestreview-702386658": invalid syntax

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1980531: Remove check for two sections in help menu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2021

@kdoberst: An error was encountered searching for external tracker bugs for bug 1980531 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. could not parse external identifier "openshift/console/pull/9385#pullrequestreview-702386658" as pull: invalid pull identifier: could not parse 9385#pullrequestreview-702386658 as number: strconv.Atoi: parsing "9385#pullrequestreview-702386658": invalid syntax

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1980531: Remove check for two sections in help menu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants