New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add topology data model factory for bindable resources #9713
Add topology data model factory for bindable resources #9713
Conversation
a63517c
to
7182570
Compare
frontend/packages/topology/src/bindable-services/fetch-bindable-services-utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/topology/src/bindable-services/fetch-bindable-services-utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/topology/src/bindable-services/data-transformer.ts
Outdated
Show resolved
Hide resolved
/hold This requires adding support for providing resources through a function instead of supplying the object. |
7182570
to
b5c890f
Compare
8ebc522
to
f80f3eb
Compare
/hold cancel Will be proceeding with fetching bindable service CR on page load, since redesigning dynamic extension requires additional effort. |
f80f3eb
to
de15818
Compare
de15818
to
ba8f492
Compare
frontend/packages/dev-console/src/components/topology/bindable-services/models.ts
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/topology/bindable-services/models.ts
Show resolved
Hide resolved
kind: 'BindableService', | ||
plural: 'BindableServices', | ||
label: 'BindableService', | ||
labelPlural: 'BindableServices', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
labelPlural: 'BindableServices', | |
labelPlural: 'Bindable Services', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sahil143 @rottencandy
The latest localization uses the same PascalCasing as the kind in the label. Have a look at https://github.com/openshift/console/blob/master/frontend/public/models/index.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted label
& labelPlural
to PascalCase.
ba8f492
to
61fb113
Compare
26437a2
to
69da08c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally with dummy CRD and CR
kind: CustomResourceDefinition
apiVersion: apiextensions.k8s.io/v1
metadata:
name: bindableservices.binding.operators.coreos.com
spec:
group: config.openshift.io
names:
plural: bindableservices
singular: bindableservice
kind: BindableService
listKind: BindableServiceList
scope: Cluster
versions:
- name: v1alpha1
served: true
storage: true
schema:
openAPIV3Schema:
description: >-
Bindable Services demo.
Compatibility level 1: Stable within a major release for a minimum of 12 months or 3 minor releases (whichever is longer).
type: object
required:
- spec
properties:
apiVersion:
description: >-
APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the
latest internal value, and may reject unrecognized values. More
info:
https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
type: string
kind:
description: >-
Kind is a string value representing the REST resource this
object represents. Servers may infer this from the endpoint the
client submits requests to. Cannot be updated. In CamelCase.
More info:
https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
type: string
metadata:
type: object
spec:
description: spec holds user settable values for configuration
type: array
items:
type: object
properties:
group:
type: string
version:
type: string
kind:
type: string
Resource
apiVersion: binding.operators.coreos.com/v1alpha1
kind: BindableService
metadata:
name: bindable-services
spec:
- group: camel.apache.org
kind: IntegrationPlatform
version: v1
Bindable resource with external-service label
Bindable resource without an external-service label is not visualized
UI breaks when clicking on a Bindable node to open the Sidebar but it's being fixed in #9841
/label qe-approved |
/label px-approved docs-approved Added label on behalf of doc, px since epic https://issues.redhat.com/browse/ODC-5722 has ack from docs and px and AC hasn't changed |
frontend/packages/dev-console/src/components/topology/bindable-services/models.ts
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/topology/bindable-services/models.ts
Outdated
Show resolved
Hide resolved
69da08c
to
5e39830
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/label px-approved Added label on behalf of doc, px since epic https://issues.redhat.com/browse/ODC-5722 has ack from docs and px and AC hasn't changed |
@@ -0,0 +1,4 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file since you're using devconsole
for i18n strings now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
5e39830
to
df01f6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm tested locally, works as expected |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rohitkrai03, rottencandy, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test all |
Fixes:
https://issues.redhat.com/browse/ODC-6160
Description:
Contribute topology data model factory for bindable services as a dynamic extension.
List of bindable resources is fetched up front because topology extensions require list of resources to be already present.
Screen shots / Gifs for design review:
N/A
Unit test coverage report:
Browser conformance:
/kind feature