Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PF packages to 2021-10 #9717

Merged
merged 2 commits into from Aug 9, 2021
Merged

Conversation

jcaianirh
Copy link
Member

Remove some previously needed translate="no" props due to react/types version mismatch as they are no longer needed for the menu components.

@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin component/shared Related to console-shared labels Aug 3, 2021
@spadgett
Copy link
Member

spadgett commented Aug 3, 2021

/cc @sg00dwin

@openshift-ci openshift-ci bot requested a review from sg00dwin August 3, 2021 21:01
@spadgett
Copy link
Member

spadgett commented Aug 3, 2021

@jcaianirh This bump makes our vendor bundle almost 50% larger:

Main vendor bundle size: 4.73 MiB
FAILURE: Main vendor bundle is larger than the 3.25 MiB limit.

@jcaianirh
Copy link
Member Author

jcaianirh commented Aug 3, 2021

@jcaianirh This bump makes our vendor bundle almost 50% larger:

Main vendor bundle size: 4.73 MiB
FAILURE: Main vendor bundle is larger than the 3.25 MiB limit.

@spadgett yes, there is a victory-core mismatch (between pf and console) causing duplication. checking with the pf folks, we can remove our entry in package.json as this dependency is already present with the pf-charts dependency. testing a new package.json now.

@jcaianirh
Copy link
Member Author

/retest

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/label px-approved
/label docs-approved

No user visible changs, so adding px- and docs-approved labels.

/assign @yapei
for QE review

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Aug 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, sg00dwin, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 5, 2021
@yapei
Copy link
Contributor

yapei commented Aug 9, 2021

Did a regression tests about action menu item and lists, no issues found
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 9, 2021
@openshift-ci openshift-ci bot merged commit 1104990 into openshift:master Aug 9, 2021
@spadgett spadgett added this to the v4.9 milestone Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/pipelines Related to pipelines-plugin component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants