New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PF packages to 2021-10 #9717
Conversation
/cc @sg00dwin |
@jcaianirh This bump makes our vendor bundle almost 50% larger:
|
@spadgett yes, there is a victory-core mismatch (between pf and console) causing duplication. checking with the pf folks, we can remove our entry in package.json as this dependency is already present with the pf-charts dependency. testing a new package.json now. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/label px-approved
/label docs-approved
No user visible changs, so adding px- and docs-approved labels.
/assign @yapei
for QE review
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaianirh, sg00dwin, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Did a regression tests about action menu item and lists, no issues found |
Remove some previously needed translate="no" props due to react/types version mismatch as they are no longer needed for the menu components.