Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PF packages to 2021-10 #9717

Merged
merged 2 commits into from Aug 9, 2021
Merged

Update PF packages to 2021-10 #9717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a28d2fd
Update PF packages to 2021-10
jcaianirh Aug 3, 2021
ac13f9c
remove victory mismatch causing larger footprint
jcaianirh Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 8 additions & 9 deletions frontend/package.json
View file
Open in desktop
Expand Up @@ -121,15 +121,15 @@
},
"dependencies": {
"@fortawesome/fontawesome-free": "^5.9.0",
"@patternfly/patternfly": "4.122.2",
"@patternfly/patternfly": "4.125.3",
"@patternfly/quickstarts": "1.1.0",
"@patternfly/react-catalog-view-extension": "4.12.15",
"@patternfly/react-charts": "6.15.8",
"@patternfly/react-core": "4.135.15",
"@patternfly/react-table": "4.29.16",
"@patternfly/react-tokens": "4.12.5",
"@patternfly/react-topology": "4.9.21",
"@patternfly/react-virtualized-extension": "4.8.53",
"@patternfly/react-catalog-view-extension": "4.12.36",
"@patternfly/react-charts": "6.15.14",
"@patternfly/react-core": "4.147.0",
"@patternfly/react-table": "4.29.37",
"@patternfly/react-tokens": "4.12.9",
"@patternfly/react-topology": "4.9.42",
"@patternfly/react-virtualized-extension": "4.9.11",
"@rjsf/core": "^2.5.1",
"abort-controller": "3.0.0",
"ajv": "^6.12.3",
Expand Down Expand Up @@ -199,7 +199,6 @@
"umd-compat-loader": "2.1.1",
"url-polyfill": "^1.1.5",
"url-search-params-polyfill": "2.x",
"victory-core": "^35.3.5",
"vscode-languageserver-types": "^3.10.0",
"whatwg-fetch": "2.x",
"xterm": "^4.10.0",
Expand Down
3 changes: 1 addition & 2 deletions frontend/packages/console-shared/src/components/actions/menu/ActionMenuContent.tsx
View file
Open in desktop
Expand Up @@ -85,7 +85,6 @@ const SubMenuContent: React.FC<GroupMenuContentProps> = ({ option, onClick }) =>
onKeyDown={handleNodeKeyDown}
data-test-action={option.id}
tabIndex={0}
translate="no"
>
{option.label}
</MenuItem>
Expand Down Expand Up @@ -129,7 +128,7 @@ const ActionMenuContent: React.FC<ActionMenuContentProps> = ({ options, onClick,
const sortedOptions = orderExtensionBasedOnInsertBeforeAndAfter(options);
return (
<MenuContent data-test-id="action-items" translate="no">
<MenuList translate="no">
<MenuList>
{sortedOptions.map((option) => {
const optionType = getMenuOptionType(option);
switch (optionType) {
Expand Down
1 change: 0 additions & 1 deletion frontend/packages/console-shared/src/components/actions/menu/ActionMenuItem.tsx
View file
Open in desktop
Expand Up @@ -61,7 +61,6 @@ const ActionItem: React.FC<ActionMenuItemProps & { isAllowed: boolean }> = ({
isDisabled={isDisabled}
data-test-action={label}
tabIndex={0} // Override PF tabIndex -1 to make action items tabbable
translate="no" // Need to pass translate="no" as a workaround to a bug in @types/react.
{...(external ? { to: href, isExternalLink: external } : {})}
>
{label}
Expand Down
6 changes: 3 additions & 3 deletions ...kages/pipelines-plugin/src/components/shared/common/auto-complete/AutoCompletePopover.tsx
View file
Open in desktop
Expand Up @@ -62,18 +62,18 @@ const AutoCompletePopover: React.FC<AutoCompletePopoverProps> = ({
}
}}
>
<MenuList translate="no">
<MenuList>
{options.length === 0 ? (
// There is a tab-index problem with the Menus from PF. If the first option is removed, it breaks tab indexes
// Need key 0 because of PF bug
<MenuItem key={0} itemId={-1} translate="no" isDisabled>
<MenuItem key={0} itemId={-1} isDisabled>
{t('pipelines-plugin~No options matching your criteria')}
</MenuItem>
) : (
options.map((value, idx) => (
// Using index-based keys to get around PF bug, see above
// eslint-disable-next-line react/no-array-index-key
<MenuItem key={idx} itemId={idx} translate="no">
<MenuItem key={idx} itemId={idx}>
{value}
</MenuItem>
))
Expand Down