Bug 1989876: Fix routing for ODF 4.9(OCS) Dashboard and link Ceph Block Pools #9722
Conversation
openshift-ci
bot
added
bugzilla/severity-low
|
@bipuladh: This pull request references Bugzilla bug 1989876, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
component/ceph
bipuladh
force-pushed
the
fix-dashboard
branch
2 times, most recently
from
3c1af99
to
6688742
Compare
|
this DetailsCard should be imported from /persistent-external/details-card but here we are using the one imported from /persistent-internal/details-card
|
Never mind, we already have a BZ (#1991095) for it now. I will fix this and send a small patch. |
|
/retest |
| }, | ||
| { | ||
| href: 'pools', | ||
| name: t('ceph-storage-plugin~Storage pools'), |
There was a problem hiding this comment.
As discussed with @yuvalgalanti already better keep heading as BlockPools:
{
href: referenceForModel(CephBlockPoolModel),
name: t('ceph-storage-plugin~BlockPools'),
|
|
||
| const breadcrumbs = [ | ||
| { | ||
| name: t('ceph-storage-plugin~Storage systems'), |
There was a problem hiding this comment.
| name: t('ceph-storage-plugin~Storage systems'), | |
| name: t('ceph-storage-plugin~StorageSystems'), |
Its a CRD name
| path: '/odf/systems', | ||
| }, | ||
| { | ||
| name: t('ceph-storage-plugin~Storage system details'), |
There was a problem hiding this comment.
| name: t('ceph-storage-plugin~Storage system details'), | |
| name: t('ceph-storage-plugin~StorageSystem details'), |
| }, | ||
| ]; | ||
|
|
||
| const title = (rest.match.params as any).systemName; |
There was a problem hiding this comment.
| const title = (rest.match.params as any).systemName; | |
| const title = systemName; |
bipuladh
force-pushed
the
fix-dashboard
branch
2 times, most recently
from
317d7fe
to
370c497
Compare
| const breadcrumbs = [ | ||
| { | ||
| name: t('ceph-storage-plugin~StorageSystems'), | ||
| path: '/odf/systems', |
There was a problem hiding this comment.
is StorageSystem list page is linked to this URL?
| @@ -379,6 +379,9 @@ | |||
| "Storage Efficiency": "Storage Efficiency", | |||
| "OpenShift Container Storage Overview": "OpenShift Container Storage Overview", | |||
| "Block and File": "Block and File", | |||
| "Storage pools": "Storage pools", | |||
| "Storage systems": "Storage systems", | |||
| "Storage system details": "Storage system details", | |||
bipuladh
force-pushed
the
fix-dashboard
branch
from
370c497
to
d091d6d
Compare
|
/LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, GowthamShanmugam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bipuladh: An error was encountered searching for external tracker bugs for bug 1989876 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
could not unmarshal response body: invalid character '<' looking for beginning of value
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@bipuladh: All pull requests linked via external trackers have merged: Bugzilla bug 1989876 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @GowthamShanmugam