Bug 1995612: Breadcrumbs link fix for block pool related pages #9772

GowthamShanmugam · 2021-08-10T10:28:36Z

This PR is top of: #9722
Issue: https://issues.redhat.com/browse/RHSTOR-2090, https://issues.redhat.com/browse/RHSTOR-2073

GowthamShanmugam · 2021-08-10T10:53:52Z

GowthamShanmugam · 2021-08-11T06:32:52Z

frontend/packages/ceph-storage-plugin/src/utils/block-pool.tsx

@@ -208,7 +208,7 @@ export const FooterPrimaryActions = (t: TFunction) => ({

 export const isDefaultPool = (blockPoolConfig: StoragePoolKind): boolean =>
  !!blockPoolConfig?.metadata.ownerReferences?.find(
-    (ownerReference) => ownerReference.name === OCS_INTERNAL_CR_NAME,


The name might change often in future release, better check with kind

bipuladh · 2021-08-16T16:08:45Z

frontend/packages/ceph-storage-plugin/src/components/block-pool/block-pool-list-page.tsx

@@ -146,7 +150,10 @@ const BlockPoolTableRow: React.FC<RowFunctionArgs> = ({ obj, index, key, style,
        className={blockPoolColumnInfo.name.classes}
        columnID={blockPoolColumnInfo.name.id}
      >
-        <ResourceLink kind={referenceFor(obj)} name={name} namespace={namespace} />
+        <ResourceIcon kind={referenceForModel(CephBlockPoolModel)} />
+        <Link to={to} className="co-resource-item__resource-name" data-test-operand-link={name}>


Suggested change

<Link to={to} className="co-resource-item__resource-name" data-test-operand-link={name}>

<Link to={to} className="co-resource-item__resource-name" data-test={name}>

This is not an operand link. We are not in the operators page.

bipuladh · 2021-08-16T16:09:11Z

frontend/packages/ceph-storage-plugin/src/components/block-pool/block-pool-list-page.tsx

 };

 type BlockPoolListProps = {
  data: StoragePoolKind[];
+  customData: any;


Suggested change

customData: any;

customData: string;

GowthamShanmugam · 2021-08-17T13:23:40Z

@bipuladh Changes done

openshift-ci · 2021-08-19T13:59:31Z

@GowthamShanmugam: This pull request references Bugzilla bug 1995612, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1995612: Breadcrumbs link fix for block pool related pages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

GowthamShanmugam · 2021-08-19T13:59:40Z

/refresh bugzilla

GowthamShanmugam · 2021-08-19T14:00:19Z

/bugzilla refresh

openshift-ci · 2021-08-19T14:00:29Z

@GowthamShanmugam: This pull request references Bugzilla bug 1995612, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-19T16:23:10Z

@GowthamShanmugam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/kubevirt-plugin	`efbd098`	link	`/test kubevirt-plugin`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>

bipuladh

/lgtm

bipuladh

/lgtm

bipuladh · 2021-08-25T05:14:43Z

frontend/packages/ceph-storage-plugin/src/components/block-pool/create-block-pool.tsx

@@ -41,8 +38,10 @@ const CreateBlockPool: React.FC<CreateBlockPoolProps> = ({ match }) => {

  const cephCluster: CephClusterKind = useDeepCompareMemoize(cephClusters[0], true);

-  const blockPoolPageUrl = url.replace('/~new', '');
-  const pathName = appName || 'BlockPools';
+  // OCS create pool page url ends with ~new, ODF create pool page ends with /create/~new


This should be removed in 4.10

openshift-ci · 2021-08-25T05:15:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, GowthamShanmugam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-08-25T07:47:28Z

@GowthamShanmugam: All pull requests linked via external trackers have merged:

openshift/console#9772

Bugzilla bug 1995612 has been moved to the MODIFIED state.

In response to this:

Bug 1995612: Breadcrumbs link fix for block pool related pages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. component/backend Related to backend component/ceph Related to ceph-storage-plugin component/core Related to console core functionality labels Aug 10, 2021

openshift-ci bot requested review from andrewballantyne and bipuladh August 10, 2021 10:28

GowthamShanmugam force-pushed the block_pool_dashboard_link_fix branch from efbd098 to 507c334 Compare August 10, 2021 10:36

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2021

GowthamShanmugam force-pushed the block_pool_dashboard_link_fix branch from 507c334 to 63c3a64 Compare August 10, 2021 10:48

GowthamShanmugam changed the title ~~Block pool dashboard link fix~~ Breadcrumbs link fix for block pool related pages Aug 10, 2021

GowthamShanmugam force-pushed the block_pool_dashboard_link_fix branch from 63c3a64 to 0c54d13 Compare August 11, 2021 06:31

GowthamShanmugam commented Aug 11, 2021

View reviewed changes

GowthamShanmugam force-pushed the block_pool_dashboard_link_fix branch from 0c54d13 to 37d3866 Compare August 16, 2021 12:47

bipuladh reviewed Aug 16, 2021

View reviewed changes

GowthamShanmugam force-pushed the block_pool_dashboard_link_fix branch 2 times, most recently from 1623a93 to bce490f Compare August 17, 2021 09:46

GowthamShanmugam force-pushed the block_pool_dashboard_link_fix branch 2 times, most recently from f6b8614 to 1d804f8 Compare August 17, 2021 20:15

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2021

GowthamShanmugam changed the title ~~Breadcrumbs link fix for block pool related pages~~ Bug 1995612: Breadcrumbs link fix for block pool related pages Aug 19, 2021

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 19, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 19, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 19, 2021

GowthamShanmugam force-pushed the block_pool_dashboard_link_fix branch from 1d804f8 to 5eaf0d9 Compare August 19, 2021 14:26

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2021

GowthamShanmugam force-pushed the block_pool_dashboard_link_fix branch from 5eaf0d9 to 7b79883 Compare August 19, 2021 15:55

Fixing breadcrumbs link issue for block pool

0917a17

Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>

GowthamShanmugam force-pushed the block_pool_dashboard_link_fix branch from 7b79883 to 0917a17 Compare August 20, 2021 14:10

bipuladh reviewed Aug 25, 2021

View reviewed changes

openshift-ci bot assigned bipuladh Aug 25, 2021

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 25, 2021

bipuladh reviewed Aug 25, 2021

View reviewed changes

openshift-merge-robot merged commit 9da79cd into openshift:master Aug 25, 2021

spadgett added this to the v4.9 milestone Aug 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1995612: Breadcrumbs link fix for block pool related pages #9772

Bug 1995612: Breadcrumbs link fix for block pool related pages #9772

GowthamShanmugam commented Aug 10, 2021 •

edited

GowthamShanmugam commented Aug 10, 2021 •

edited

GowthamShanmugam Aug 11, 2021

bipuladh Aug 16, 2021

GowthamShanmugam Aug 17, 2021

bipuladh Aug 16, 2021

GowthamShanmugam Aug 17, 2021

GowthamShanmugam commented Aug 17, 2021

openshift-ci bot commented Aug 19, 2021

GowthamShanmugam commented Aug 19, 2021

GowthamShanmugam commented Aug 19, 2021

openshift-ci bot commented Aug 19, 2021

openshift-ci bot commented Aug 19, 2021 •

edited

bipuladh left a comment

bipuladh left a comment

bipuladh Aug 25, 2021

GowthamShanmugam Aug 25, 2021

openshift-ci bot commented Aug 25, 2021

openshift-ci bot commented Aug 25, 2021

	<Link to={to} className="co-resource-item__resource-name" data-test-operand-link={name}>
	<Link to={to} className="co-resource-item__resource-name" data-test={name}>

Bug 1995612: Breadcrumbs link fix for block pool related pages #9772

Bug 1995612: Breadcrumbs link fix for block pool related pages #9772

Conversation

GowthamShanmugam commented Aug 10, 2021 • edited

GowthamShanmugam commented Aug 10, 2021 • edited

GowthamShanmugam Aug 11, 2021

Choose a reason for hiding this comment

bipuladh Aug 16, 2021

Choose a reason for hiding this comment

GowthamShanmugam Aug 17, 2021

Choose a reason for hiding this comment

bipuladh Aug 16, 2021

Choose a reason for hiding this comment

GowthamShanmugam Aug 17, 2021

Choose a reason for hiding this comment

GowthamShanmugam commented Aug 17, 2021

openshift-ci bot commented Aug 19, 2021

GowthamShanmugam commented Aug 19, 2021

GowthamShanmugam commented Aug 19, 2021

openshift-ci bot commented Aug 19, 2021

openshift-ci bot commented Aug 19, 2021 • edited

bipuladh left a comment

Choose a reason for hiding this comment

bipuladh left a comment

Choose a reason for hiding this comment

bipuladh Aug 25, 2021

Choose a reason for hiding this comment

GowthamShanmugam Aug 25, 2021

Choose a reason for hiding this comment

openshift-ci bot commented Aug 25, 2021

openshift-ci bot commented Aug 25, 2021

GowthamShanmugam commented Aug 10, 2021 •

edited

GowthamShanmugam commented Aug 10, 2021 •

edited

openshift-ci bot commented Aug 19, 2021 •

edited