Bug 1978649: Block and File and Object dashboards should not be part of OCP Console for ODF Managed Services #9742

SanjalKatiyar · 2021-08-05T14:28:45Z

Disabled Block and File and Object dashboards for ODF Managed Services.
Storage --> Overview navigation item will be hidden.
Storage --> OpenShift Data Foundation navigation item will also be hidden. (added in patch Hide ODF dashboard for ODF Managed Services red-hat-storage/odf-console#1)

openshift-ci · 2021-08-05T14:28:52Z

@SanjalKatiyar: This pull request references Bugzilla bug 1978649, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 1978649: Block and File and Object dashboards should not be part of OCP Console for ODF Managed Services

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-05T15:27:07Z

@SanjalKatiyar: This pull request references Bugzilla bug 1978649, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 1978649: Block and File and Object dashboards should not be part of OCP Console for ODF Managed Services

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SanjalKatiyar · 2021-08-05T15:34:00Z

frontend/packages/ceph-storage-plugin/src/features.ts

+  try {
+    const ns = await k8sGet(NamespaceModel, CEPH_STORAGE_NAMESPACE);
+    if (ns) {
+      const isManagedCluster = ns?.metadata?.labels?.[ODF_MANAGED_LABEL];


Label added to the openshift-storage ns for ODF managed services: https://gitlab.cee.redhat.com/service/managed-tenants/-/merge_requests/1100

openshift-ci · 2021-08-06T11:22:45Z

@SanjalKatiyar: This pull request references Bugzilla bug 1978649, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 1978649: Block and File and Object dashboards should not be part of OCP Console for ODF Managed Services

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23 · 2021-08-10T06:48:53Z

/assign @bipuladh
Since he has been aware of the changes

afreen23 · 2021-08-12T09:56:59Z

/test ceph-storage-plugin

frontend/packages/ceph-storage-plugin/src/features.ts

SanjalKatiyar · 2021-08-18T06:45:39Z

/test ceph-storage-plugin

bipuladh · 2021-08-18T06:56:46Z

Talked to Ohad. The namespace will be labelled initially so we should not have an issue.
/lgtm

openshift-ci · 2021-08-18T06:57:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-08-18T10:10:22Z

@SanjalKatiyar: All pull requests linked via external trackers have merged:

openshift/console#9742

Bugzilla bug 1978649 has been moved to the MODIFIED state.

In response to this:

Bug 1978649: Block and File and Object dashboards should not be part of OCP Console for ODF Managed Services

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SanjalKatiyar · 2021-08-19T16:47:46Z

/cherry-pick release-4.8

SanjalKatiyar · 2021-08-19T16:47:54Z

/cherry-pick release-4.7

openshift-cherrypick-robot · 2021-08-19T16:48:23Z

@SanjalKatiyar: #9742 failed to apply on top of branch "release-4.8":

Applying: disable Overview nav item for ODF Managed
Using index info to reconstruct a base tree...
M	frontend/packages/ceph-storage-plugin/console-extensions.json
M	frontend/packages/ceph-storage-plugin/src/plugin.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/ceph-storage-plugin/src/plugin.ts
CONFLICT (content): Merge conflict in frontend/packages/ceph-storage-plugin/src/plugin.ts
Auto-merging frontend/packages/ceph-storage-plugin/console-extensions.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 disable Overview nav item for ODF Managed
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-08-19T16:48:31Z

@SanjalKatiyar: #9742 failed to apply on top of branch "release-4.7":

Applying: disable Overview nav item for ODF Managed
Using index info to reconstruct a base tree...
M	frontend/packages/ceph-storage-plugin/console-extensions.json
A	frontend/packages/ceph-storage-plugin/src/constants/common.ts
M	frontend/packages/ceph-storage-plugin/src/features.ts
M	frontend/packages/ceph-storage-plugin/src/plugin.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/ceph-storage-plugin/src/plugin.ts
CONFLICT (content): Merge conflict in frontend/packages/ceph-storage-plugin/src/plugin.ts
Auto-merging frontend/packages/ceph-storage-plugin/src/features.ts
CONFLICT (content): Merge conflict in frontend/packages/ceph-storage-plugin/src/features.ts
Auto-merging frontend/packages/ceph-storage-plugin/src/constants/index.ts
CONFLICT (content): Merge conflict in frontend/packages/ceph-storage-plugin/src/constants/index.ts
Auto-merging frontend/packages/ceph-storage-plugin/console-extensions.json
CONFLICT (content): Merge conflict in frontend/packages/ceph-storage-plugin/console-extensions.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 disable Overview nav item for ODF Managed
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 5, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 5, 2021

openshift-ci bot requested review from afreen23 and shyRozen August 5, 2021 14:28

openshift-ci bot added component/ceph Related to ceph-storage-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Aug 5, 2021

SanjalKatiyar force-pushed the disable_ocs_dashboard branch from d0825f5 to 0040050 Compare August 5, 2021 15:23

SanjalKatiyar commented Aug 5, 2021

View reviewed changes

disable Overview nav item for ODF Managed

06be2c4

SanjalKatiyar force-pushed the disable_ocs_dashboard branch from 0040050 to 06be2c4 Compare August 6, 2021 11:09

SanjalKatiyar mentioned this pull request Aug 6, 2021

Hide ODF dashboard for ODF Managed Services red-hat-storage/odf-console#1

Merged

openshift-ci bot assigned bipuladh Aug 10, 2021

bipuladh reviewed Aug 12, 2021

View reviewed changes

frontend/packages/ceph-storage-plugin/src/features.ts Show resolved Hide resolved

frontend/packages/ceph-storage-plugin/src/features.ts Show resolved Hide resolved

bipuladh approved these changes Aug 16, 2021

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2021

openshift-ci bot merged commit ff72e9b into openshift:master Aug 18, 2021

spadgett added this to the v4.9 milestone Aug 30, 2021

This was referenced Aug 31, 2021

disable OCS dashboard for managed services #9946

Closed

Bug 1999717: Block and File and Object dashboards should not be part of OCP Console for ODF Managed Services #9952

Merged

SanjalKatiyar mentioned this pull request Sep 17, 2021

Bug 2005298: Block and File and Object dashboards should not be part of OCP Console for ODF Managed Services #10097

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1978649: Block and File and Object dashboards should not be part of OCP Console for ODF Managed Services #9742

Bug 1978649: Block and File and Object dashboards should not be part of OCP Console for ODF Managed Services #9742

SanjalKatiyar commented Aug 5, 2021 •

edited

Loading

openshift-ci bot commented Aug 5, 2021

openshift-ci bot commented Aug 5, 2021

SanjalKatiyar Aug 5, 2021

openshift-ci bot commented Aug 6, 2021

afreen23 commented Aug 10, 2021

afreen23 commented Aug 12, 2021

SanjalKatiyar commented Aug 18, 2021

bipuladh commented Aug 18, 2021

openshift-ci bot commented Aug 18, 2021

openshift-ci bot commented Aug 18, 2021

SanjalKatiyar commented Aug 19, 2021

SanjalKatiyar commented Aug 19, 2021

openshift-cherrypick-robot commented Aug 19, 2021

openshift-cherrypick-robot commented Aug 19, 2021

Bug 1978649: Block and File and Object dashboards should not be part of OCP Console for ODF Managed Services #9742

Bug 1978649: Block and File and Object dashboards should not be part of OCP Console for ODF Managed Services #9742

Conversation

SanjalKatiyar commented Aug 5, 2021 • edited Loading

openshift-ci bot commented Aug 5, 2021

openshift-ci bot commented Aug 5, 2021

SanjalKatiyar Aug 5, 2021

Choose a reason for hiding this comment

openshift-ci bot commented Aug 6, 2021

afreen23 commented Aug 10, 2021

afreen23 commented Aug 12, 2021

SanjalKatiyar commented Aug 18, 2021

bipuladh commented Aug 18, 2021

openshift-ci bot commented Aug 18, 2021

openshift-ci bot commented Aug 18, 2021

SanjalKatiyar commented Aug 19, 2021

SanjalKatiyar commented Aug 19, 2021

openshift-cherrypick-robot commented Aug 19, 2021

openshift-cherrypick-robot commented Aug 19, 2021

SanjalKatiyar commented Aug 5, 2021 •

edited

Loading