Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console-2951: Prune unused styles from getting started card #9808

Merged

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Aug 16, 2021

No longer needed since #9532 has merged.

@openshift-ci openshift-ci bot added the component/shared Related to console-shared label Aug 16, 2021
@sg00dwin sg00dwin changed the title Prune unused styles from getting started card Console-2951: Prune unused styles from getting started card Aug 17, 2021
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2021
@rhamilto
Copy link
Member

rhamilto commented Aug 20, 2021

/label px-approved docs-approved

as this is tech debt without the need for either approvals

/assign @yapei for QE approval

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2021

@rhamilto: GitHub didn't allow me to assign the following users: for, QE, approval.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/label px-approved docs-approved

as this is tech debt without

/assign @yapei for QE approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto rhamilto added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Aug 20, 2021
@yapei
Copy link
Contributor

yapei commented Aug 23, 2021

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit 8e86fcb into openshift:master Aug 23, 2021
@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
@sg00dwin sg00dwin deleted the getting-started-style-cleanup branch January 26, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants