Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1996792: Fix quick search modal missing icons #9856

Merged
merged 1 commit into from Aug 31, 2021
Merged

Bug 1996792: Fix quick search modal missing icons #9856

merged 1 commit into from Aug 31, 2021

Conversation

vikram-raj
Copy link
Member

@vikram-raj vikram-raj commented Aug 23, 2021 •
edited

Fixes:
https://issues.redhat.com/browse/ODC-6248

Analysis / Root cause:
The quick search results icons are missing.

Solution Description:

  • Fix extra left padding
  • Show icon for the item.

Screen shots / Gifs for design review:
Before:
image

After:
image
image

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot added the component/shared Related to console-shared label Aug 23, 2021
@vikram-raj
Copy link
Member Author

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 23, 2021
@vikram-raj vikram-raj changed the title Fix quick search modal missing icons Bug 1996792: Fix quick search modal missing icons Aug 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2021

@vikram-raj: This pull request references Bugzilla bug 1996792, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1996792: Fix quick search modal missing icons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 23, 2021
@karthikjeeyar
Copy link
Contributor

5 items should be visible on the left without the scrollbar, I think the height calculation here needs to be fixed as well.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 27, 2021

@vikram-raj: This pull request references Bugzilla bug 1996792, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1996792: Fix quick search modal missing icons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj vikram-raj force-pushed the odc-6248 branch 2 times, most recently from 353d777 to 6c54a1e Compare August 27, 2021 15:31
@vikram-raj
Copy link
Member Author

5 items should be visible on the left without the scrollbar, I think the height calculation here needs to be fixed as well.

Fixed this. PTAL.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 27, 2021

@vikram-raj: This pull request references Bugzilla bug 1996792, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1996792: Fix quick search modal missing icons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj
Copy link
Member Author

/test frontend

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2021

@vikram-raj: This pull request references Bugzilla bug 1996792, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1996792: Fix quick search modal missing icons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karthikjeeyar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2021
andrewballantyne
andrewballantyne approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this was not the goal that was set out to do, I think we can keep it as-is. But there are definite ways we should improve this -- like using a flex container and have a min and max size. But that's not really needed to fix this issue.

frontend/packages/console-shared/src/components/quick-search/QuickSearchModalBody.tsx
@@ -44,7 +44,7 @@ const QuickSearchModalBody: React.FC<QuickSearchModalBodyProps> = ({
viewContainer,
}) => {
const DEFAULT_HEIGHT_WITH_NO_ITEMS = 60;
const DEFAULT_HEIGHT_WITH_ITEMS = 400;
const DEFAULT_HEIGHT_WITH_ITEMS = 483;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this change is not really going to be a thing we can chase. We should definitely have a dynamic one.

Eg:
Screen Shot 2021-08-31 at 11 50 44 AM
Screen Shot 2021-08-31 at 11 50 56 AM

@andrewballantyne
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, karthikjeeyar, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021
@openshift-merge-robot openshift-merge-robot merged commit fe0e598 into openshift:master Aug 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@vikram-raj: All pull requests linked via external trackers have merged:

Bugzilla bug 1996792 has been moved to the MODIFIED state.

In response to this:

Bug 1996792: Fix quick search modal missing icons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj vikram-raj deleted the odc-6248 branch September 1, 2021 05:26
@spadgett spadgett added this to the v4.9 milestone Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinandan13jan abhinandan13jan abhinandan13jan left review comments

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@karthikjeeyar karthikjeeyar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/shared Related to console-shared kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vikram-raj @karthikjeeyar @andrewballantyne @abhinandan13jan @spadgett @openshift-merge-robot