Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1996792: Fix quick search modal missing icons #9856

Merged
merged 1 commit into from Aug 31, 2021
Merged

Bug 1996792: Fix quick search modal missing icons #9856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion frontend/packages/console-shared/src/components/quick-search/QuickSearchList.scss
View file
Open in desktop
Expand Up @@ -9,6 +9,7 @@
var(--pf-c-data-list--sm--BorderTopColor) !important;
flex: 1;
overflow-y: auto;
margin-bottom: 0 !important;
}
&__item {
border-bottom: var(--pf-c-data-list__item--sm--BorderBottomWidth) solid
Expand All @@ -26,13 +27,14 @@
}
}
&__item-row {
padding: 0 var(--pf-global--spacer--sm);
padding: 0 var(--pf-global--spacer--sm) !important;
}
&__item-content {
align-items: center;
}
&__item-icon {
width: 30px;
text-align: center;
}
&__item-name {
font-size: var(--pf-global--FontSize--md);
Expand Down
4 changes: 3 additions & 1 deletion frontend/packages/console-shared/src/components/quick-search/QuickSearchList.tsx
View file
Open in desktop
Expand Up @@ -114,7 +114,9 @@ const QuickSearchList: React.FC<QuickSearchListProps> = ({
className="ocs-quick-search-list__item-content"
dataListCells={[
<DataListCell isIcon key={`${item.uid}-icon`}>
{item.icon?.node ?? getIcon(item)}
<div className="ocs-quick-search-list__item-icon">
vikram-raj marked this conversation as resolved.
Show resolved Hide resolved
{item.icon?.node ?? getIcon(item)}
</div>
</DataListCell>,
<DataListCell
style={{ paddingTop: 'var(--pf-global--spacer--sm)' }}
Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/console-shared/src/components/quick-search/QuickSearchModalBody.tsx
View file
Open in desktop
Expand Up @@ -44,7 +44,7 @@ const QuickSearchModalBody: React.FC<QuickSearchModalBodyProps> = ({
viewContainer,
}) => {
const DEFAULT_HEIGHT_WITH_NO_ITEMS = 60;
const DEFAULT_HEIGHT_WITH_ITEMS = 400;
const DEFAULT_HEIGHT_WITH_ITEMS = 483;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this change is not really going to be a thing we can chase. We should definitely have a dynamic one.

Eg:
Screen Shot 2021-08-31 at 11 50 44 AM
Screen Shot 2021-08-31 at 11 50 56 AM

const MIN_HEIGHT = 240;
const MIN_WIDTH = 225;
const [catalogItems, setCatalogItems] = React.useState<CatalogItem[]>(null);
Expand Down