Bug 1994117: delete hardcodes and orphaned code #9870

maudem · 2021-08-24T15:21:02Z

delete:

alert-manager.tsx
chargeback.tsx
cluster-service-class.tsx
instantiate-template.tsx
prometheus.jsx
service-instance.tsx
and associated code

openshift-ci · 2021-08-24T15:26:11Z

@maudem: This pull request references Bugzilla bug 1994117, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1994117: delete hardcodes and orphaned code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett

Thanks @maudem. There are some additional things we need to check for and remove for all of these, including:

Any orphaned CSS styles
Any orphaned models in k8s-models.ts
Any orphaned YAML templates in yaml-templates.ts
Any orphaned feature flags (e.g., FLAGS.CHARGEBACK)
Any orphaned table sorts or filters (table.tsx, table-filters.ts)
Any orphaned tests for these components

All of service catalog should be removed, which includes some additional resources.

instantiate-template.tsx should NOT be removed.

spadgett · 2021-08-24T15:31:13Z

frontend/public/components/instantiate-template.tsx

@@ -1,387 +0,0 @@
-import * as React from 'react';


This file should NOT be removed. This is a feature we want to keep in console.

@spadgett this file was included in the hardcode list and in bugzilla. Was there another list I should have looked at for the files I needed to remove?

I think it was just incorrectly marked as one to remove.

spadgett · 2021-08-24T15:35:45Z

frontend/public/components/broker-management.tsx

@@ -1,19 +1,13 @@
 import * as React from 'react';


This entire file should be removed as well. Service catalog includes

Service Brokers
Service Classes
Service Instances
Service Bindings

Be careful about service bindings since there is another kind of service binding that is used in the dev console that should not be removed. Only the service catalog bindings should be removed.

We also need to remove the protractor tests for service catalog and any models as well as the custom table filters, YAML templates, and feature flags.

spadgett · 2021-08-24T15:36:01Z

frontend/public/components/app-contents.tsx

@@ -270,28 +269,6 @@ const AppContents: React.FC<{}> = () => {
                }
              />

-              <LazyRoute
-                path="/catalog/instantiate-template"


instantiate-template should stay.

spadgett · 2021-08-24T15:37:49Z

frontend/public/components/chargeback.tsx

@@ -1,682 +0,0 @@
-import * as React from 'react';


Please remove any associated models, YAML templates, and feature flags (CHARGEBACK, CAN_LIST_CHARGEBACK_REPORTS) for chargeback.

https://github.com/spadgett/console/blob/5ed583c6ecb31fa6b4f1ad4dbf771cdc6a20aa27/frontend/public/models/yaml-templates.ts#L196-L227

https://github.com/spadgett/console/blob/5ed583c6ecb31fa6b4f1ad4dbf771cdc6a20aa27/frontend/public/models/index.ts#L54-L84

spadgett · 2021-08-24T15:40:46Z

frontend/public/components/cluster-service-broker.tsx

@@ -17,7 +17,6 @@ import {
 import { K8sResourceKind, referenceForModel } from '../module/k8s';


This entire file should be removed.

spadgett · 2021-08-24T15:41:24Z

frontend/public/components/prometheus.jsx

@@ -1,114 +0,0 @@
-import * as React from 'react';


Please remove any associated models.

spadgett · 2021-08-24T15:41:44Z

frontend/public/components/alert-manager.tsx

@@ -1,164 +0,0 @@
-import * as React from 'react';


Please remove any associated models.

spadgett · 2021-08-24T15:42:01Z

frontend/public/components/provisioned-services.tsx

@@ -1,20 +1,7 @@
 import * as React from 'react';


This entire file should be removed.

maudem · 2021-08-25T20:40:53Z

/bugzilla refresh

openshift-ci · 2021-08-27T18:53:35Z

@maudem: This pull request references Bugzilla bug 1994117, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1994117: delete hardcodes and orphaned code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maudem · 2021-09-17T15:56:31Z

/bugzilla refresh

openshift-ci · 2021-09-17T15:57:08Z

@maudem: This pull request references Bugzilla bug 1994117, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-10-08T15:04:20Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maudem
To complete the pull request process, please assign vojtechszocs after the PR has been reviewed.
You can assign the PR to them by writing /assign @vojtechszocs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

maudem · 2021-10-21T17:59:31Z

/retest

openshift-ci · 2021-10-21T18:00:34Z

@maudem: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test analyze
/test backend
/test ceph-storage-plugin
/test e2e-gcp-console
/test frontend
/test images
/test kubevirt-plugin

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-console-master-analyze
pull-ci-openshift-console-master-backend
pull-ci-openshift-console-master-e2e-gcp-console
pull-ci-openshift-console-master-frontend
pull-ci-openshift-console-master-images

In response to this:

/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maudem · 2021-10-21T18:45:43Z

/retest

maudem · 2021-11-01T15:29:10Z

/retest

maudem · 2021-11-01T19:12:36Z

/retest-required

maudem · 2021-11-02T20:03:02Z

/retest-required

maudem · 2021-11-08T21:56:09Z

/retest-required

maudem · 2021-11-11T17:25:26Z

/hold e2e test pass blocked by https://bugzilla.redhat.com/2022452

maudem · 2021-11-15T12:39:06Z

/retest-required

delete references to cluster service broker in yaml-template delete alert-manager and associated code delete chargeback.tsx and associated code delete cluster-service-class.tsx, instantiate-template.tsx, and associated code delete prometheus.jsx and associated code delete service-instance.tsx and associated code Bring back instantiate-template.tsx Revert "delete files for Service Brokers" This reverts commit 9f40bd78cb0fdaac10e8d6aadc188818c6633d23. bring back instantiate-template delete files for Service Brokers delete Service Brokers in yaml-templates Revert "delete Service Brokers in yaml-templates" This reverts commit 36bcbb7b31b6947aa4a5f84ce62cebb0286c89e9. remove broker management file delete references to cluster service broker model in resource pages and lazy routes for provisioned services find last remaining links and references to cluster service brokers, provisioned services, and broker mgt delete unused models delete custom styling and lazyroutes for alert manager delete alert manager tests and such delete more code relater to cluster service classes delete custom service instance styles update translations Update public.json

maudem · 2021-11-24T20:26:11Z

/retest-required

openshift-ci · 2021-11-24T21:57:29Z

@maudem: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	`81a74c1`	link	true	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-02-22T23:06:47Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-ci · 2022-02-22T23:06:55Z

@maudem: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-24T23:29:45Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2022-04-23T23:59:47Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2022-04-24T00:00:14Z

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-04-24T00:00:21Z

@maudem: This pull request references Bugzilla bug 1994117. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Bug 1994117: delete hardcodes and orphaned code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from jeff-phillips-18 and kyoto August 24, 2021 15:27

openshift-ci bot added the component/core Related to console core functionality label Aug 24, 2021

spadgett requested changes Aug 24, 2021

View reviewed changes

maudem force-pushed the bugfix-remove-obselete-code branch from b75feef to 1f3c694 Compare September 29, 2021 19:00

openshift-ci bot added component/olm Related to OLM component/shared Related to console-shared kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Sep 29, 2021

maudem force-pushed the bugfix-remove-obselete-code branch 2 times, most recently from 1ce8ccc to 0c75c20 Compare September 30, 2021 03:52

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2021

maudem force-pushed the bugfix-remove-obselete-code branch from 1340776 to af8c8c5 Compare September 30, 2021 13:20

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2021

maudem force-pushed the bugfix-remove-obselete-code branch 2 times, most recently from 1ce8ccc to b22cb1c Compare September 30, 2021 14:03

openshift-ci bot added component/sdk Related to console-plugin-sdk and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 4, 2021

maudem force-pushed the bugfix-remove-obselete-code branch from 7054346 to 2eaeac0 Compare October 8, 2021 14:54

openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 8, 2021

spadgett mentioned this pull request Oct 14, 2021

Bug 2014248: i18n several missed files #10244

Merged

rebeccaalpert mentioned this pull request Oct 20, 2021

Bug 2014245: i18n several aria-labels, external links, and labels #10245

Merged

maudem requested a review from spadgett October 21, 2021 18:07

maudem force-pushed the bugfix-remove-obselete-code branch from c5465ec to fad439f Compare October 21, 2021 18:09

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2021

maudem force-pushed the bugfix-remove-obselete-code branch from fad439f to 81a74c1 Compare November 15, 2021 20:10

openshift-ci bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 22, 2022

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 24, 2022

openshift-ci bot closed this Apr 24, 2022

rhamilto mentioned this pull request Apr 26, 2022

Bug 1994117: remove orphaned Service Catalog and Chargeback code #11400

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1994117: delete hardcodes and orphaned code #9870

Bug 1994117: delete hardcodes and orphaned code #9870

maudem commented Aug 24, 2021 •

edited

openshift-ci bot commented Aug 24, 2021

spadgett left a comment •

edited

spadgett Aug 24, 2021

maudem Aug 26, 2021

spadgett Aug 26, 2021

spadgett Aug 24, 2021

spadgett Aug 24, 2021

spadgett Aug 24, 2021

spadgett Aug 24, 2021

spadgett Aug 24, 2021

spadgett Aug 24, 2021

spadgett Aug 24, 2021

maudem commented Aug 25, 2021

openshift-ci bot commented Aug 27, 2021

maudem commented Sep 17, 2021

openshift-ci bot commented Sep 17, 2021

openshift-ci bot commented Oct 8, 2021

maudem commented Oct 21, 2021 •

edited

openshift-ci bot commented Oct 21, 2021

maudem commented Oct 21, 2021

maudem commented Nov 1, 2021

maudem commented Nov 1, 2021

maudem commented Nov 2, 2021

maudem commented Nov 8, 2021

maudem commented Nov 11, 2021

maudem commented Nov 15, 2021

maudem commented Nov 24, 2021

openshift-ci bot commented Nov 24, 2021

openshift-bot commented Feb 22, 2022

openshift-ci bot commented Feb 22, 2022

openshift-bot commented Mar 24, 2022

openshift-bot commented Apr 23, 2022

openshift-ci bot commented Apr 24, 2022

openshift-ci bot commented Apr 24, 2022

		@@ -17,7 +17,6 @@ import {
		import { K8sResourceKind, referenceForModel } from '../module/k8s';

Bug 1994117: delete hardcodes and orphaned code #9870

Bug 1994117: delete hardcodes and orphaned code #9870

Conversation

maudem commented Aug 24, 2021 • edited

openshift-ci bot commented Aug 24, 2021

spadgett left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maudem commented Aug 25, 2021

openshift-ci bot commented Aug 27, 2021

maudem commented Sep 17, 2021

openshift-ci bot commented Sep 17, 2021

openshift-ci bot commented Oct 8, 2021

maudem commented Oct 21, 2021 • edited

openshift-ci bot commented Oct 21, 2021

maudem commented Oct 21, 2021

maudem commented Nov 1, 2021

maudem commented Nov 1, 2021

maudem commented Nov 2, 2021

maudem commented Nov 8, 2021

maudem commented Nov 11, 2021

maudem commented Nov 15, 2021

maudem commented Nov 24, 2021

openshift-ci bot commented Nov 24, 2021

openshift-bot commented Feb 22, 2022

openshift-ci bot commented Feb 22, 2022

openshift-bot commented Mar 24, 2022

openshift-bot commented Apr 23, 2022

openshift-ci bot commented Apr 24, 2022

openshift-ci bot commented Apr 24, 2022

maudem commented Aug 24, 2021 •

edited

spadgett left a comment •

edited

maudem commented Oct 21, 2021 •

edited