Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Bug 1725832: 4.2 backport build loopback with no_openssl tag #19

Closed
wants to merge 1 commit into from

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Oct 24, 2019

  • build loopback with no_openssl tag for FIPS compliance
  • build with CGO_ENABLED=1 to avoid static linking in glibc

Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

(backport #18 to release-4.3)
@dougbtv PTAL

- build loopback with no_openssl tag for FIPS compliance
- build with CGO_ENABLED=1 to avoid static linking in glibc

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@openshift-ci-robot
Copy link
Contributor

@lsm5: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

RE: rhbz#1725832

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lsm5
To complete the pull request process, please assign s1061123
You can assign the PR to them by writing /assign @s1061123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
Copy link
Member Author

lsm5 commented Oct 24, 2019

/retest

@dougbtv
Copy link
Member

dougbtv commented Oct 24, 2019

/retitle BZ 1725832: 4.2 backport build loopback with no_openssl tag

@openshift-ci-robot openshift-ci-robot changed the title RE: rhbz#1725832 BZ 1725832: 4.2 backport build loopback with no_openssl tag Oct 24, 2019
@openshift-ci-robot
Copy link
Contributor

@lsm5: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

BZ 1725832: 4.2 backport build loopback with no_openssl tag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dougbtv
Copy link
Member

dougbtv commented Oct 24, 2019

/retitle Bug 1725832: 4.2 backport build loopback with no_openssl tag

@openshift-ci-robot openshift-ci-robot changed the title BZ 1725832: 4.2 backport build loopback with no_openssl tag Bug 1725832: 4.2 backport build loopback with no_openssl tag Oct 24, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 24, 2019
@openshift-ci-robot
Copy link
Contributor

@lsm5: This pull request references Bugzilla bug 1725832, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1725832: 4.2 backport build loopback with no_openssl tag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cuppett
Copy link
Member

cuppett commented Oct 24, 2019

/test e2e-aws

@openshift-ci-robot
Copy link
Contributor

@lsm5: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 2341519 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@squeed
Copy link
Contributor

squeed commented Oct 25, 2019

Why do this? Loopback will never make network connections. It already doesn't staticly link glibc - it's a go binary.

@lsm5 lsm5 changed the title Bug 1725832: 4.2 backport build loopback with no_openssl tag [DO NOT MERGE] Bug 1725832: 4.2 backport build loopback with no_openssl tag Oct 25, 2019
@lsm5 lsm5 closed this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants