[release-4.13] OCPBUGS-28205: UPSTREAM: 6277: openshift: Fix OCPBUGS-28205

[gcs278]

4.13 Cherry-Pick of coredns#6277 (I actually cherry-picked #112 to receive the merge resolution from 4.14) which fixes OCPBUGS-28200 by adding logic that more gracefully handles overflow errors by setting the Truncated Bit and clearing the response. This indicates to DNS clients to retry with TCP, whereas previously they would have always gotten a SERVFAIL.

This becomes more important/exposed with CoreDNS 1.10.1 (OCP 4.13) onwards, given the changes introduced by coredns#5671. This modification only uses EDNS on the upstream DNS request when the client query used EDNS. It appears that certain DNS resolvers may not handle non-EDNS queries in a compliant manner.

Cherry-Pick Merge Conflict:

CONFLICT (modify/delete): plugin/pkg/proxy/proxy_test.go deleted in HEAD and modified in 37a9afe69 (UPSTREAM: 6277: openshift: Fix OCPBUGS-27397).  Version 37a9afe69 (UPSTREAM: 6277: openshift: Fix OCPBUGS-27397) of plugin/pkg/proxy/proxy_test.go left in tree.

• plugin/pkg/proxy directory doesn't exist in release-4.14 due to refactoring, so I placed the unit tests in plugin/forward/proxy_test.go
• Required some refactoring due to function signature changes and other refactoring

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-28205, which is invalid:

• expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

4.13 Cherry-Pick of coredns#6277 (I actually cherry-picked #112 to receive the merge resolution from 4.14) which fixes OCPBUGS-28200 by adding logic that more gracefully handles overflow errors by setting the Truncated Bit and clearing the response. This indicates to DNS clients to retry with TCP, whereas previously they would have always gotten a SERVFAIL.

This becomes more important/exposed with CoreDNS 1.10.1 (OCP 4.13) onwards, given the changes introduced by coredns#5671. This modification only uses EDNS on the upstream DNS request when the client query used EDNS. It appears that certain DNS resolvers may not handle non-EDNS queries in a compliant manner.

Cherry-Pick Merge Conflict:

CONFLICT (modify/delete): plugin/pkg/proxy/proxy_test.go deleted in HEAD and modified in 37a9afe69 (UPSTREAM: 6277: openshift: Fix OCPBUGS-27397).  Version 37a9afe69 (UPSTREAM: 6277: openshift: Fix OCPBUGS-27397) of plugin/pkg/proxy/proxy_test.go left in tree.

• plugin/pkg/proxy directory doesn't exist in release-4.14 due to refactoring, so I placed the unit tests in plugin/forward/proxy_test.go
• Required some refactoring due to function signature changes and other refactoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-28205, which is invalid:

• expected dependent Jira Issue OCPBUGS-28200 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

4.13 Cherry-Pick of coredns#6277 (I actually cherry-picked #112 to receive the merge resolution from 4.14) which fixes OCPBUGS-28200 by adding logic that more gracefully handles overflow errors by setting the Truncated Bit and clearing the response. This indicates to DNS clients to retry with TCP, whereas previously they would have always gotten a SERVFAIL.

This becomes more important/exposed with CoreDNS 1.10.1 (OCP 4.13) onwards, given the changes introduced by coredns#5671. This modification only uses EDNS on the upstream DNS request when the client query used EDNS. It appears that certain DNS resolvers may not handle non-EDNS queries in a compliant manner.

Cherry-Pick Merge Conflict:

CONFLICT (modify/delete): plugin/pkg/proxy/proxy_test.go deleted in HEAD and modified in 37a9afe69 (UPSTREAM: 6277: openshift: Fix OCPBUGS-27397).  Version 37a9afe69 (UPSTREAM: 6277: openshift: Fix OCPBUGS-27397) of plugin/pkg/proxy/proxy_test.go left in tree.

• plugin/pkg/proxy directory doesn't exist in release-4.14 due to refactoring, so I placed the unit tests in plugin/forward/proxy_test.go
• Required some refactoring due to function signature changes and other refactoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Miciah]

Lovely jubbly
/approve
/lgtm

As with the original change, this change only affects the behavior when we already have an error and the upstream resolver is probably misbehaving. Furthermore, the changes in this PR (the release-4.13 backport) are identical to the changes in #112 (the release-4.14 backport).
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[melvinjoseph86]

/label cherry-pick-approved

[openshift-ci]

@gcs278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn	f9806df	link	true	/test e2e-aws-ovn
ci/prow/unit	f9806df	link	true	/test unit
ci/prow/images	f9806df	link	true	/test images
ci/prow/e2e-aws-ovn-upgrade	f9806df	link	true	/test e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn	f9806df	link	false	/test e2e-metal-ipi-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sreber84]

/retest-required

[melvinjoseph86]

/retest-required

[melvinjoseph86]

/jira refresh

[openshift-ci-robot]

@melvinjoseph86: This pull request references Jira Issue OCPBUGS-28205, which is invalid:

• expected dependent Jira Issue OCPBUGS-28200 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[melvinjoseph86]

/test e2e-gcp-serial

[openshift-ci]

@melvinjoseph86: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test e2e-aws-ovn
• /test e2e-aws-ovn-upgrade
• /test e2e-gcp-sdn-serial
• /test images
• /test unit

The following commands are available to trigger optional jobs:

• /test e2e-metal-ipi-ovn
• /test e2e-metal-ipi-ovn-dualstack

Use /test all to run the following jobs that were automatically triggered:

• pull-ci-openshift-coredns-release-4.13-e2e-aws-ovn
• pull-ci-openshift-coredns-release-4.13-e2e-aws-ovn-upgrade
• pull-ci-openshift-coredns-release-4.13-e2e-gcp-sdn-serial
• pull-ci-openshift-coredns-release-4.13-e2e-metal-ipi-ovn
• pull-ci-openshift-coredns-release-4.13-images
• pull-ci-openshift-coredns-release-4.13-unit

In response to this:

/test e2e-gcp-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[melvinjoseph86]

/retest

[melvinjoseph86]

/retest

[sreber84]

/jira refresh

[openshift-ci-robot]

@sreber84: This pull request references Jira Issue OCPBUGS-28205, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.z) matches configured target version for branch (4.13.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-28200 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-28200 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
• bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: melvinjoseph86.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sreber84: This pull request references Jira Issue OCPBUGS-28205, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.z) matches configured target version for branch (4.13.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-28200 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-28200 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
• bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

The e2e-gcp-serial job doesn't exist for this repository or branch, so it shouldn't even be reported, much less blocking this PR.
/override ci/prow/e2e-gcp-serial

[openshift-ci]

@Miciah: Overrode contexts on behalf of Miciah: ci/prow/e2e-gcp-serial

In response to this:

The e2e-gcp-serial job doesn't exist for this repository or branch, so it shouldn't even be reported, much less blocking this PR.
/override ci/prow/e2e-gcp-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[melvinjoseph86]

Tested this PR with cluster bot.
/label qe-approved

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-28205, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.z) matches configured target version for branch (4.13.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-28200 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-28200 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
• bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

4.13 Cherry-Pick of coredns#6277 (I actually cherry-picked #112 to receive the merge resolution from 4.14) which fixes OCPBUGS-28200 by adding logic that more gracefully handles overflow errors by setting the Truncated Bit and clearing the response. This indicates to DNS clients to retry with TCP, whereas previously they would have always gotten a SERVFAIL.

This becomes more important/exposed with CoreDNS 1.10.1 (OCP 4.13) onwards, given the changes introduced by coredns#5671. This modification only uses EDNS on the upstream DNS request when the client query used EDNS. It appears that certain DNS resolvers may not handle non-EDNS queries in a compliant manner.

Cherry-Pick Merge Conflict:

CONFLICT (modify/delete): plugin/pkg/proxy/proxy_test.go deleted in HEAD and modified in 37a9afe69 (UPSTREAM: 6277: openshift: Fix OCPBUGS-27397).  Version 37a9afe69 (UPSTREAM: 6277: openshift: Fix OCPBUGS-27397) of plugin/pkg/proxy/proxy_test.go left in tree.

• plugin/pkg/proxy directory doesn't exist in release-4.14 due to refactoring, so I placed the unit tests in plugin/forward/proxy_test.go
• Required some refactoring due to function signature changes and other refactoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: melvinjoseph86.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@gcs278: This pull request references Jira Issue OCPBUGS-28205, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.z) matches configured target version for branch (4.13.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-28200 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-28200 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
• bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

4.13 Cherry-Pick of coredns#6277 (I actually cherry-picked #112 to receive the merge resolution from 4.14) which fixes OCPBUGS-28200 by adding logic that more gracefully handles overflow errors by setting the Truncated Bit and clearing the response. This indicates to DNS clients to retry with TCP, whereas previously they would have always gotten a SERVFAIL.

This becomes more important/exposed with CoreDNS 1.10.1 (OCP 4.13) onwards, given the changes introduced by coredns#5671. This modification only uses EDNS on the upstream DNS request when the client query used EDNS. It appears that certain DNS resolvers may not handle non-EDNS queries in a compliant manner.

Cherry-Pick Merge Conflict:

CONFLICT (modify/delete): plugin/pkg/proxy/proxy_test.go deleted in HEAD and modified in 37a9afe69 (UPSTREAM: 6277: openshift: Fix OCPBUGS-27397).  Version 37a9afe69 (UPSTREAM: 6277: openshift: Fix OCPBUGS-27397) of plugin/pkg/proxy/proxy_test.go left in tree.

• plugin/pkg/proxy directory doesn't exist in release-4.14 due to refactoring, so I placed the unit tests in plugin/forward/proxy_test.go
• Required some refactoring due to function signature changes and other refactoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@gcs278: Jira Issue OCPBUGS-28205: All pull requests linked via external trackers have merged:

• openshift/coredns#113

Jira Issue OCPBUGS-28205 has been moved to the MODIFIED state.

In response to this:

4.13 Cherry-Pick of coredns#6277 (I actually cherry-picked #112 to receive the merge resolution from 4.14) which fixes OCPBUGS-28200 by adding logic that more gracefully handles overflow errors by setting the Truncated Bit and clearing the response. This indicates to DNS clients to retry with TCP, whereas previously they would have always gotten a SERVFAIL.

This becomes more important/exposed with CoreDNS 1.10.1 (OCP 4.13) onwards, given the changes introduced by coredns#5671. This modification only uses EDNS on the upstream DNS request when the client query used EDNS. It appears that certain DNS resolvers may not handle non-EDNS queries in a compliant manner.

Cherry-Pick Merge Conflict:

CONFLICT (modify/delete): plugin/pkg/proxy/proxy_test.go deleted in HEAD and modified in 37a9afe69 (UPSTREAM: 6277: openshift: Fix OCPBUGS-27397).  Version 37a9afe69 (UPSTREAM: 6277: openshift: Fix OCPBUGS-27397) of plugin/pkg/proxy/proxy_test.go left in tree.

• plugin/pkg/proxy directory doesn't exist in release-4.14 due to refactoring, so I placed the unit tests in plugin/forward/proxy_test.go
• Required some refactoring due to function signature changes and other refactoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build coredns-container-v4.13.0-202402020908.p0.g298d919.assembly.stream for distgit coredns.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.13.0-0.nightly-2024-02-02-103131