[release-4.14] OCPBUGS-28200: UPSTREAM: 6277: openshift: Fix OCPBUGS-28200 #114
Conversation
Handle UDP responses that overflow with TC bit with test case (coredns#6277) Signed-off-by: SriHarshaBS001 <SriHarshaBS009@gmail.com> Modified-by: Grant Spence <gspence@redhat.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/close |
|
@gcs278: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
/open |
|
@gcs278: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
gcs278
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@gcs278: This pull request references Jira Issue OCPBUGS-28200, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: melvinjoseph86. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
gcs278
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/assign @Miciah |
|
https://patch-diff.githubusercontent.com/raw/openshift/coredns/pull/112.patch and https://patch-diff.githubusercontent.com/raw/openshift/coredns/pull/114.patch are identical, so the approvals in #112 (comment) carry over. |
openshift-ci
bot
added
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/retest |
|
Tested this PR with cluster bot. |
openshift-ci
bot
added
the
qe-approved
|
/retest |
|
/skip |
|
Tide is showing that e2e-gcp-serial was run for #112 and the master branch, but this is #114 and the release-4.14 branch. Something is really broken here. Let's try overriding the bogus test... |
|
/override ci/prow/e2e-gcp-serial |
|
@Miciah: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Miciah: Overrode contexts on behalf of Miciah: ci/prow/e2e-gcp-serial In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gcs278: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 7d3fa77
into
openshift:release-4.14
|
@gcs278: Jira Issue OCPBUGS-28200: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-28200 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build coredns-container-v4.14.0-202402011639.p0.g7d3fa77.assembly.stream for distgit coredns. |
|
Fix included in accepted release 4.14.0-0.nightly-2024-02-02-015353 |
4.14 Cherry-Pick of coredns#6277 which fixes OCPBUGS-28200 by adding logic that more gracefully handles overflow errors by setting the Truncated Bit and clearing the response. This indicates to DNS clients to retry with TCP, whereas previously they would have always gotten a SERVFAIL.
This becomes more important/exposed with CoreDNS 1.10.1 (OCP 4.13) onwards, given the changes introduced by coredns#5671. This modification only uses EDNS on the upstream DNS request when the client query used EDNS. It appears that certain DNS resolvers may not handle non-EDNS queries in a compliant manner.
Cherry-Pick Merge Conflict:
plugin/pkg/proxydirectory doesn't exist in release-4.14 due to refactoring, so I placed the unit tests inplugin/forward/proxy_test.go