Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go:embed for static yaml files #179 #105

Merged
merged 2 commits into from Jun 30, 2021
Merged

Use go:embed for static yaml files #179 #105

merged 2 commits into from Jun 30, 2021

Conversation

jsafrane
Copy link
Contributor

Move from bindata to go:embed.

Contains bump of library-go and related changes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2021
@jsafrane jsafrane force-pushed the embed branch 3 times, most recently from 174f5b7 to 36a5717 Compare June 22, 2021 11:10
@jsafrane
Copy link
Contributor Author

/hold
for openshift/library-go#1117

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2021
@jsafrane
Copy link
Contributor Author

/hold cancel
updated with openshift/library-go#1117

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2021
@mandre
Copy link
Member

mandre commented Jun 24, 2021

Let's give the shiny new Manila CSI job a spin
/retest

mandre
mandre reviewed Jun 24, 2021
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for CI

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@jsafrane
Copy link
Contributor Author

Not sure what's the magic CI command to run new tests...
/refresh

@mandre
Copy link
Member

mandre commented Jun 24, 2021

Hmm, come on you can do it.
/test e2e-openstack-csi

@jsafrane
Copy link
Contributor Author

This looks like genuine failure, I don't see NFS driver DaemonSet.

@jsafrane
Use go:embed for static yaml files
818bea0 
Move from bindata to go:embed.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2021
@jsafrane
Copy link
Contributor Author

Fixed replacement of ${NFS_DRIVER_IMAGE} in the manifest. BTW, it's awesome to see CI catching such errors!

mandre
mandre reviewed Jun 30, 2021
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI FTW!

/lgtm

@jsafrane please remove the hold at your convenience.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021
@jsafrane
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2773207 into openshift:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@bertinatto bertinatto Awaiting requested review from bertinatto

@huffmanca huffmanca Awaiting requested review from huffmanca

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsafrane @mandre @openshift-merge-robot