Bug 1991814: Move namespace creation to cluster-storage-operator

[jsafrane]

The namespace must exist to compose correct RelatedObjects in CSO.
See openshift/cluster-storage-operator#202 for details.

[openshift-ci]

@jsafrane: This pull request references Bugzilla bug 1991814, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to this:

Bug 1991814: Move namespace creation to cluster-storage-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

/hold
for openshift/cluster-storage-operator#202 to be merged first.

[mandre]

Will this still collect the objects from the openshift-manila-csi-driver namespace upon must-gather?

[jsafrane]

It should, together with openshift/cluster-storage-operator#202. Manila namespace should still be collected on all OpenStack installations.

[mandre]

It should, together with openshift/cluster-storage-operator#202. Manila namespace should still be collected on all OpenStack installations.

I'm asking because unless I missed something you remove openshift-manila-csi-driver from must-gather log collection in https://github.com/openshift/cluster-storage-operator/pull/202/files#diff-0d623dfd885adb20f991bda4c2453aebd732ca6dbb4d1d4be6e79805c3b48de6L60.

[jsafrane]

It should be added by the controller automatically when processing 01_namespace.yaml - all objects in the yaml files will be added to RelatedObjects.

[mandre]

Thanks for the explanation,
/lgtm

[jsafrane]

@mandre , can you remove your /hold?

[jsafrane]

Sorry, wrong PR :-) It's my /hold :-D

[mandre]

Can we just ensure we run the e2e-openstack-csi job before removing the /hold, once openshift/cluster-storage-operator#202 merges ?

[jsafrane]

/retest

[jsafrane]

/retest

[jsafrane]

/retest

[openshift-ci]

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-openstack-csi	bd89cde	link	/test e2e-openstack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jsafrane]

/hold cancel
CI looks good, I can see only known bugs there

[openshift-ci]

@jsafrane: All pull requests linked via external trackers have merged:

• openshift/cluster-storage-operator#202
• openshift/csi-driver-manila-operator#115

Bugzilla bug 1991814 has been moved to the MODIFIED state.

In response to this:

Bug 1991814: Move namespace creation to cluster-storage-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.