Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] Bug 2001958: Do not degrade cluster on failure to reach Manila #122

Merged
merged 1 commit into from Sep 9, 2021
Merged

[release-4.9] Bug 2001958: Do not degrade cluster on failure to reach Manila #122

merged 1 commit into from Sep 9, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #120

/assign mandre

@mandre
Bug 2001620: Do not degrade cluster on failure to reach Manila
ef1dcd8 
It's possible that for one reason or another we're unable to reach the
Manila endpoint. In the past we've tried to be smart and handled errors
differently, if it's a 404, a 403, or other types of errors. The
problem with this approach is that it's very easy to forget valid
failure cases. We've had a recent example with proxy setting not
correctly propagated to the Manila pod and degrading the cluster.

We should instead treat all failures to reach the Manila endpoint as
a non fatal error and disable the Manila operator instead of making the
cluster degraded.

This makes the Manila operator consistent with the EFS one.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 7, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

@openshift-cherrypick-robot: Bugzilla bug 2001620 has been cloned as Bugzilla bug 2001958. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2001958: Do not degrade cluster on failure to reach Manila

In response to this:

[release-4.9] Bug 2001620: Do not degrade cluster on failure to reach Manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2001620: Do not degrade cluster on failure to reach Manila [release-4.9] Bug 2001958: Do not degrade cluster on failure to reach Manila Sep 7, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2001958, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2001620 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2001620 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

[release-4.9] Bug 2001958: Do not degrade cluster on failure to reach Manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack-csi ef1dcd8 link /test e2e-openstack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eurijon
Copy link

eurijon commented Sep 9, 2021

/lgtm
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 9, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@sdodson sdodson added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Sep 9, 2021
@sdodson
Copy link
Member

sdodson commented Sep 9, 2021

/approve
Approved as this is tied to a customer facing issue we're trying to resolve in 4.6.

@sdodson sdodson added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit fd2d838 into openshift:release-4.9 Sep 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2001958 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2001958: Do not degrade cluster on failure to reach Manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurijon eurijon Awaiting requested review from eurijon

@bertinatto bertinatto Awaiting requested review from bertinatto

@tombarron tombarron Awaiting requested review from tombarron

Assignees

@mandre mandre

@eurijon eurijon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @eurijon @sdodson @mandre @openshift-merge-robot