-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.9] Bug 2001958: Do not degrade cluster on failure to reach Manila #122
[release-4.9] Bug 2001958: Do not degrade cluster on failure to reach Manila #122
Conversation
It's possible that for one reason or another we're unable to reach the Manila endpoint. In the past we've tried to be smart and handled errors differently, if it's a 404, a 403, or other types of errors. The problem with this approach is that it's very easy to forget valid failure cases. We've had a recent example with proxy setting not correctly propagated to the Manila pod and degrading the cluster. We should instead treat all failures to reach the Manila endpoint as a non fatal error and disable the Manila operator instead of making the cluster degraded. This makes the Manila operator consistent with the EFS one.
@openshift-cherrypick-robot: Bugzilla bug 2001620 has been cloned as Bugzilla bug 2001958. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2001958, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: openshift-cherrypick-robot, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 2001958 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #120
/assign mandre