[release-4.6] Bug 2002556: Do not degrade cluster on failure to reach Manila #127
Conversation
It's possible that for one reason or another we're unable to reach the Manila endpoint. In the past we've tried to be smart and handled errors differently, if it's a 404, a 403, or other types of errors. The problem with this approach is that it's very easy to forget valid failure cases. We've had a recent example with proxy setting not correctly propagated to the Manila pod and degrading the cluster. We should instead treat all failures to reach the Manila endpoint as a non fatal error and disable the Manila operator instead of making the cluster degraded. This makes the Manila operator consistent with the EFS one.
openshift-ci
bot
added
the
bugzilla/severity-urgent
|
@mandre: This pull request references Bugzilla bug 2002556, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/invalid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2002556, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2002556, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2002556, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2002556, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2002556, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
openshift-ci
bot
added
the
qe-approved
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2002556, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@rlobillo: This pull request references Bugzilla bug 2002556, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (rlobillo@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[patch-manager] Approving cherry pick with score 2.0, urgent bz, 4.7 PR landed and verified |
hardys
added
the
cherry-pick-approved
|
@mandre: All pull requests linked via external trackers have merged: Bugzilla bug 2002556 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It's possible that for one reason or another we're unable to reach the
Manila endpoint. In the past we've tried to be smart and handled errors
differently, if it's a 404, a 403, or other types of errors. The
problem with this approach is that it's very easy to forget valid
failure cases. We've had a recent example with proxy setting not
correctly propagated to the Manila pod and degrading the cluster.
We should instead treat all failures to reach the Manila endpoint as
a non fatal error and disable the Manila operator instead of making the
cluster degraded.
This makes the Manila operator consistent with the EFS one.