Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.6] Bug 2002556: Do not degrade cluster on failure to reach Manila #127

Merged

Commits on Sep 9, 2021

  1. Bug 2002556: Do not degrade cluster on failure to reach Manila

    It's possible that for one reason or another we're unable to reach the
    Manila endpoint. In the past we've tried to be smart and handled errors
    differently, if it's a 404, a 403, or other types of errors. The
    problem with this approach is that it's very easy to forget valid
    failure cases. We've had a recent example with proxy setting not
    correctly propagated to the Manila pod and degrading the cluster.
    
    We should instead treat all failures to reach the Manila endpoint as
    a non fatal error and disable the Manila operator instead of making the
    cluster degraded.
    
    This makes the Manila operator consistent with the EFS one.
    mandre committed Sep 9, 2021
    Copy the full SHA
    1294d82 View commit details
    Browse the repository at this point in the history