Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-16250: Add management workloads annotations #195

Merged
merged 1 commit into from Sep 4, 2023
Merged

[release-4.13] OCPBUGS-16250: Add management workloads annotations #195

merged 1 commit into from Sep 4, 2023

Conversation

Phaow
Copy link
Contributor

@Phaow Phaow commented Aug 1, 2023

This is a manual cherry-pick of #175 , fix the OCPBUGS-16250.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 1, 2023
@openshift-ci-robot
Copy link
Contributor

@Phaow: This pull request references Jira Issue OCPBUGS-16250, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-8683 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-8683 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @Phaow

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #175 , fix the OCPBUGS-16250.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: Phaow.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@Phaow: This pull request references Jira Issue OCPBUGS-16250, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-8683 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-8683 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @Phaow

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #175 , fix the OCPBUGS-16250.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dobsonj and tsmetana August 1, 2023 10:58
@jsafrane
Copy link
Contributor

jsafrane commented Aug 1, 2023

/approve
/lgtm
/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023

@jsafrane: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to this:

/approve
/lgtm
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Phaow
Copy link
Contributor Author

Phaow commented Aug 1, 2023

/label cherry-pick-approved

@jsafrane
Copy link
Contributor

jsafrane commented Aug 9, 2023

/approve
/lgtm
/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

@jsafrane: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to this:

/approve
/lgtm
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, Phaow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 15, 2023
Merged
@Phaow
Copy link
Contributor Author

Phaow commented Aug 16, 2023

@mandre Could you please take a look and add the backport-risk-assessed label ?
@itzikb-redhat Could you please take a look and add the cherry-pick-approved label ?
Thanks in advance!

@eurijon
Copy link

eurijon commented Sep 4, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 4, 2023
mandre
mandre reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 4, 2023
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 4, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 496fd48 and 2 for PR HEAD fcf623a in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2023

@Phaow: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b1295cd into openshift:release-4.13 Sep 4, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@Phaow: Jira Issue OCPBUGS-16250: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-16250 has not been moved to the MODIFIED state.

In response to this:

This is a manual cherry-pick of #175 , fix the OCPBUGS-16250.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 6, 2023
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build csi-driver-manila-operator-container-v4.13.0-202311211131.p0.gb1295cd.assembly.stream for distgit csi-driver-manila-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@dobsonj dobsonj Awaiting requested review from dobsonj

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@jsafrane jsafrane

@eurijon eurijon

@itzikb-redhat itzikb-redhat

@rlobillo rlobillo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@Phaow @openshift-ci-robot @jsafrane @eurijon @openshift-bot @mandre @itzikb-redhat @openshift-merge-robot @rlobillo @tsmetana