Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.13] OCPBUGS-16250: Add management workloads annotations #120

Merged
merged 1 commit into from Sep 6, 2023

Conversation

Phaow
Copy link

@Phaow Phaow commented Aug 1, 2023

This is a manual cherry-pick of #116 , fix the OCPBUGS-16250.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 1, 2023
@openshift-ci-robot
Copy link

@Phaow: This pull request references Jira Issue OCPBUGS-16250, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-8683 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-8683 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @Phaow

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #116 , fix the OCPBUGS-16250.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: Phaow.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@Phaow: This pull request references Jira Issue OCPBUGS-16250, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-8683 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-8683 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @Phaow

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #116 , fix the OCPBUGS-16250.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dobsonj and engelmi August 1, 2023 11:38
@jsafrane
Copy link

jsafrane commented Aug 1, 2023

/approve
/lgtm
/label backport-risk-assessed

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

@jsafrane: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/approve
/lgtm
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 1, 2023
@Phaow
Copy link
Author

Phaow commented Aug 1, 2023

/label cherry-pick-approved

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

@Phaow: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

@Phaow: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link

jsafrane commented Aug 9, 2023

/approve
/lgtm
/label backport-risk-assessed

@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2023

@jsafrane: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/approve
/lgtm
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, Phaow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Phaow
Copy link
Author

Phaow commented Aug 16, 2023

@mburman5 Could you please help take a look and add the cherry-pick-approved when you get a chance? Thanks! BTW, do you know who can help add the backport-risk-assessed label?

@eslutsky
Copy link

eslutsky commented Sep 4, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 4, 2023
@Phaow
Copy link
Author

Phaow commented Sep 6, 2023

Checked the e2e job must-gather the annotation already added and CI looks good. We're safe to go. @leistnerova could you please help to add the cherry-pick-approved. I'm also the bug QA contact, so I could verify and double confirm again.

$ omg get deploy/ovirt-csi-driver-controller -oyaml|yq .spec.template.metadata.annotations
operator.openshift.io/dep-b3c68cb2620304d88e465c548c1c214a4acf8: O1lK1A==
operator.openshift.io/dep-c42c0d45eb927642d9a24aa98132ae4f8cacd: 8VUTtQ==
target.workload.openshift.io/management: '{"effect": "PreferredDuringScheduling"}'

@Phaow
Copy link
Author

Phaow commented Sep 6, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 6, 2023
@Phaow
Copy link
Author

Phaow commented Sep 6, 2023

/label cherry-pick-approved

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

@Phaow: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leistnerova
Copy link

/label cherry-pick-approved
Changes in metadata, no functional change. Verified by OCP QE

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit aca579d into openshift:release-4.13 Sep 6, 2023
5 checks passed
@openshift-ci-robot
Copy link

@Phaow: Jira Issue OCPBUGS-16250: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16250 has been moved to the MODIFIED state.

In response to this:

This is a manual cherry-pick of #116 , fix the OCPBUGS-16250.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants