New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.13] OCPBUGS-16250: Add management workloads annotations #120
Conversation
@Phaow: This pull request references Jira Issue OCPBUGS-16250, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: Phaow. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
@jsafrane: Can not set label backport-risk-assessed: Must be member in one of these teams: [] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label cherry-pick-approved |
@Phaow: Can not set label cherry-pick-approved: Must be member in one of these teams: [] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Phaow: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
@jsafrane: Can not set label backport-risk-assessed: Must be member in one of these teams: [] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, Phaow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mburman5 Could you please help take a look and add the |
/label backport-risk-assessed |
Checked the e2e job must-gather the annotation already added and CI looks good. We're safe to go. @leistnerova could you please help to add the $ omg get deploy/ovirt-csi-driver-controller -oyaml|yq .spec.template.metadata.annotations
operator.openshift.io/dep-b3c68cb2620304d88e465c548c1c214a4acf8: O1lK1A==
operator.openshift.io/dep-c42c0d45eb927642d9a24aa98132ae4f8cacd: 8VUTtQ==
target.workload.openshift.io/management: '{"effect": "PreferredDuringScheduling"}' |
/label qe-approved |
/label cherry-pick-approved |
@Phaow: Can not set label cherry-pick-approved: Must be member in one of these teams: [] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label cherry-pick-approved |
@Phaow: Jira Issue OCPBUGS-16250: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-16250 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a manual cherry-pick of #116 , fix the OCPBUGS-16250.