Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-26114,OCPBUGS-26081,OCPBUGS-26145: add snyk config file for SAST scan #161

Merged
merged 1 commit into from Jan 9, 2024

Conversation

gabemontero
Copy link
Contributor

Per the documented policy from ART for the SAST scans, and following the pattern established in the openshift/oc repo, we are introducing a snyk config file that excludes the vendor tree, as that is currently some minor warnings.

Per the documented policy from ART for the SAST scans, and following
the pattern established in the openshift/oc repo, we are introducing a
snyk config file that excludes the vendor tree, as that is currently some
minor warnings.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 9, 2024
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Jira Issue OCPBUGS-26114, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-26081, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-26145, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Per the documented policy from ART for the SAST scans, and following the pattern established in the openshift/oc repo, we are introducing a snyk config file that excludes the vendor tree, as that is currently some minor warnings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@gabemontero
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 9, 2024
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Jira Issue OCPBUGS-26114, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jitendar-singh

This pull request references Jira Issue OCPBUGS-26081, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jitendar-singh

This pull request references Jira Issue OCPBUGS-26145, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jitendar-singh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gabemontero
Copy link
Contributor Author

/assign @coreydaley
/assign @otaviof

@coreydaley
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

@gabemontero: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 6ed227b link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 83c961e into openshift:master Jan 9, 2024
7 of 8 checks passed
@openshift-ci-robot
Copy link

@gabemontero: Jira Issue OCPBUGS-26114: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26114 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-26081: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26081 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-26145: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26145 has been moved to the MODIFIED state.

In response to this:

Per the documented policy from ART for the SAST scans, and following the pattern established in the openshift/oc repo, we are introducing a snyk config file that excludes the vendor tree, as that is currently some minor warnings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gabemontero gabemontero deleted the snyk-cfg branch January 9, 2024 21:54
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-csi-driver-shared-resource-webhook-container-v4.16.0-202401100232.p0.g83c961e.assembly.stream for distgit ose-csi-driver-shared-resource-webhook.
All builds following this will include this PR.

@gabemontero
Copy link
Contributor Author

/cherrypick release-4.15

@openshift-cherrypick-robot

@gabemontero: new pull request created: #162

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants