BUILD-353: name changes, 2 CRDs instead of one for secrets and configmaps #55

gabemontero · 2021-09-27T21:46:27Z

in repro API should be drag and drop back to openshift/api

the 2 CRDs resulted in removing support for switching between configmaps and secrets for a "share" (a good thing IMO in hindsight)

/assign @coreydaley
/assign @adambkaplan

openshift-ci · 2021-09-27T21:46:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gabemontero · 2021-09-28T12:11:33Z

we have green e2e's on the latest rename @coreydaley @adambkaplan

coreydaley · 2021-09-28T17:09:14Z

docs/content-update-details.md

@@ -42,6 +42,7 @@ provided by this CSI driver.
 Allowing the disabling processing of updates, or switching the default for the system as not dealing with
 updates, but then allowing for opting into updates, is also under consideration.

+//TODO do we punt on this with the separate CRDs now


I think this can be removed.

coreydaley · 2021-09-28T17:09:44Z

docs/csi.md

@@ -3,13 +3,13 @@
 So let's take each part of the [CSIVolumeSource](https://github.com/kubernetes/api/blob/71efbb18d63cd30604981514ac623a6be1d413bb/core/v1/types.go#L1743-L1771):

 - for the `Driver` string field, it needs to be ["csi-driver-projected-resource.openshift.io"](https://github.com/openshift/csi-driver-shared-resource/blob/1fcc354faa31f624086265ea2228661a0fc2e7b1/pkg/client/client.go#L28).
- for the `VolumeAttributes` map, this driver currently adds the "share" key (which maps the the `SharedResource` instance your `Pod` wants to use) in addition to the
+- for the `VolumeAttributes` map, this driver currently adds the "share" key (which maps the the `SharedConfigMap` OR `SharedSecret` instance your `Pod` wants to use) in addition to the


Suggested change

- for the `VolumeAttributes` map, this driver currently adds the "share" key (which maps the the `SharedConfigMap` OR `SharedSecret` instance your `Pod` wants to use) in addition to the

- for the `VolumeAttributes` map, this driver currently adds the "share" key (which maps the `SharedConfigMap` OR `SharedSecret` instance your `Pod` wants to use) in addition to the

yeah actually the key name is not correct as well

it is sharedConfigMap or sharedSecret

I'll make that changes as well here

coreydaley · 2021-09-28T17:10:45Z

docs/install.md

+oc apply -f ./deploy/0000_10_sharedconfigmap.crd.yaml
+customresourcedefinition.apiextensions.k8s.io/sharedconfigmaps.sharedresource.openshift.io created
+deploying hostpath components
+   ./deploy/0000_10_sharedsecrets.crd.yaml


Suggested change

./deploy/0000_10_sharedsecrets.crd.yaml

./deploy/0000_10_sharedsecret.crd.yaml

coreydaley · 2021-09-28T17:13:29Z

docs/install.md

+oc apply -f --filename https://raw.githubusercontent.com/openshift/csi-driver-shared-resource/release-4.10/deploy/00-namespace.yaml
+oc apply -f --filename https://raw.githubusercontent.com/openshift/csi-driver-shared-resource/release-4.10/deploy/0000_10_sharedconfigmap.crd.yaml
+oc apply -f --filename https://raw.githubusercontent.com/openshift/csi-driver-shared-resource/release-4.10/deploy/0000_10_sharedsecret.crd.yaml
+oc apply -f --filename https://raw.githubusercontent.com/openshift/csi-driver-shared-resource/release-4.10/deploy/01-service-account.yaml 
+oc apply -f --filename https://raw.githubusercontent.com/openshift/csi-driver-shared-resource/release-4.10/deploy/02-cluster-role.yaml
+oc apply -f --filename https://raw.githubusercontent.com/openshift/csi-driver-shared-resource/release-4.10/deploy/03-cluster-role-binding.yaml
+oc apply -f --filename https://raw.githubusercontent.com/openshift/csi-driver-shared-resource/release-4.10/deploy/csi-hostpath-driverinfo.yaml
+oc apply -f --filename https://raw.githubusercontent.com/openshift/csi-driver-shared-resource/release-4.10/deploy/csi-hostpath-plugin.yaml 


Should we replace release-4.10 here with master instead?

I don't think so, as master could be unstable, once a given release goes out.

So we will have to update this readme every release?

lesser of the evils IMO ... at least for now ... and if it lags, it is not the worse thing ... and it is easy enough for someone to figure our they can tweak that to another branch

possible this just goes away or morphs into a "dev only" mode at some point, in which case we switch to master

I'd rather hold off on that while we are in this intermediate state

coreydaley · 2021-09-28T17:16:49Z

pkg/api/sharedresource/v1alpha1/share_configmap_type.go

+//
+// spec:
+//  volumes:
+//  - name: shared-secret


Suggested change

// - name: shared-secret

// - name: shared-configmap

coreydaley · 2021-09-28T17:17:23Z

pkg/api/sharedresource/v1alpha1/share_configmap_type.go

@@ -0,0 +1,73 @@
+package v1alpha1


Should this file be named shared_configmap_type.go ?

yeah and the secret one too

gabemontero · 2021-09-28T18:09:34Z

pushed updates from your comments as separate commits @coreydaley - thanks !

coreydaley · 2021-09-28T18:13:02Z

cmd/main.go

@@ -79,7 +78,9 @@ func init() {

 	rootCmd.Flags().AddGoFlagSet(flag.CommandLine)
 	rootCmd.Flags().StringVar(&endPoint, "endpoint", "unix://tmp/csi.sock", "CSI endpoint")
-	rootCmd.Flags().StringVar(&driverName, "drivername", string(v1.SharedResourcesCSIDriver), "name of the driver")
+	//rootCmd.Flags().StringVar(&driverName, "drivername", string(v1.SharedResourcesCSIDriver), "name of the driver")


Do we still need this commented out line?

I'd like to leave it as per the TODO comment below we'll swtich back to it once you've updated that driver name with your openshift/api PR

coreydaley · 2021-09-28T19:28:29Z

docs/simple-example.md

@@ -97,7 +92,7 @@ $ kubectl apply -f ./examples
 namespace/my-csi-app-namespace created
 role.rbac.authorization.k8s.io/shared-resource-my-share created
 rolebinding.rbac.authorization.k8s.io/shared-resource-my-share created
-share.sharedresource.storage.openshift.io/my-share created
+sharedconfig.sharedresource.openshift.io/my-share created


Should this be sharedconfigmap ?

coreydaley · 2021-09-28T19:28:45Z

docs/faq.md


 You'll see an event like:

 ```bash
 $ oc get events
-0s          Warning   FailedMount      pod/my-csi-app                                       MountVolume.SetUp failed for volume "my-csi-volume" : rpc error: code = InvalidArgument desc = the csi driver volumeAttribute 'share' reference had an error: sharedresource.storage.openshift.io "my-share" not found
+0s          Warning   FailedMount      pod/my-csi-app                                       MountVolume.SetUp failed for volume "my-csi-volume" : rpc error: code = InvalidArgument desc = the csi driver volumeAttribute 'share' reference had an error: sharedconfig.sharedresource.openshift.io "my-share" not found


Should this be sharedconfigmap?

gabemontero · 2021-09-28T19:33:43Z

ok @coreydaley squashed the previous review commits, add a new one for the next round of corrections from you - thanks !

coreydaley · 2021-09-28T19:31:09Z

pkg/api/sharedresource/v1alpha1/0000_10_sharedsecret.crd.yaml

@@ -0,0 +1,22 @@
+# this is the boilerplate crd def that controller-gen reads and modifies with the
+# contents from share_secret_type.go


Suggested change

# contents from share_secret_type.go

# contents from shared_secret_type.go

coreydaley · 2021-09-28T19:34:51Z

deploy/0000_10_sharedconfigmap.crd.yaml

@@ -0,0 +1,104 @@
+# this is the boilerplate crd def that controller-gen reads and modifies with the
+# contents from share_configmap_type.go


Suggested change

# contents from share_configmap_type.go

# contents from shared_configmap_type.go

coreydaley · 2021-09-28T19:35:26Z

deploy/0000_10_sharedsecret.crd.yaml

@@ -1,27 +1,27 @@
 # this is the boilerplate crd def that controller-gen reads and modifies with the
-# contents from share_type.go
+# contents from share_secret_type.go


Suggested change

# contents from share_secret_type.go

# contents from shared_secret_type.go

coreydaley · 2021-09-28T19:36:32Z

pkg/api/sharedresource/v1alpha1/shared_secret_type.go

+// +genclient:nonNamespaced
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+
+// SharedSecret allows a Secret o be shared across namespaces.


Suggested change

// SharedSecret allows a Secret o be shared across namespaces.

// SharedSecret allows a Secret to be shared across namespaces.

coreydaley · 2021-09-28T19:37:19Z

pkg/api/sharedresource/v1alpha1/shared_configmap_type.go

+//        sharedConfigMap: my-share
+//
+// For the mount to be successful, the pod's service account must be granted permission to 'use' the named SharedConfigMap object
+// within its namespace with an appropriate Role and RoleBinding.  For compactness, here are example `oc` invocations for creating


Suggested change

// within its namespace with an appropriate Role and RoleBinding. For compactness, here are example `oc` invocations for creating

// within its namespace with an appropriate Role and RoleBinding. For compactness, here are example `oc` invocations for creating

coreydaley · 2021-09-28T19:44:58Z

pkg/cache/secrets.go

@@ -44,10 +44,10 @@ var (
 	// a given secret; when possible we range over this list vs. secrets
 	secretsWithShare = sync.Map{}
 	// sharesWaitingOnSecrets conversely is for when a share has been created that references a secret, but that
-	// secret has not been recognized by the controller; quite possibly timing events on when we learn of shares
+	// secret has not been recognized by the controller; quite possibly timing events on when we learn of shareConfigMaps


Suggested change

// secret has not been recognized by the controller; quite possibly timing events on when we learn of shareConfigMaps

// secret has not been recognized by the controller; quite possibly timing events on when we learn of sharedSecrets

coreydaley · 2021-09-28T19:45:32Z

pkg/cache/secrets.go

 		secretKey := BuildKey(br)
 		secretsWithShare.Store(secretKey, secret)
-		//NOTE: share update ranger will store share in shares sync.Map
+		//NOTE: share update ranger will store share in shareConfigMaps sync.Map


Suggested change

//NOTE: share update ranger will store share in shareConfigMaps sync.Map

//NOTE: share update ranger will store share in shareSecrets sync.Map

coreydaley · 2021-09-28T19:45:51Z

pkg/cache/secrets.go

 		// and we are supplying only this specific share to the csi driver update range callbacks.
-		shareUpdateCallbacks.Range(buildRanger(buildCallbackMap(share.Name, share)))
+		shareConfigMapsUpdateCallbacks.Range(buildRanger(buildCallbackMap(share.Name, share)))


Suggested change

shareConfigMapsUpdateCallbacks.Range(buildRanger(buildCallbackMap(share.Name, share)))

shareSecretsUpdateCallbacks.Range(buildRanger(buildCallbackMap(share.Name, share)))

coreydaley · 2021-09-28T19:46:06Z

pkg/cache/secrets.go

@@ -117,7 +117,7 @@ func DelSecret(secret *corev1.Secret) {
 // storage
 func RegisterSecretUpsertCallback(volID string, f func(key, value interface{}) bool) {
 	secretUpsertCallbacks.Store(volID, f)
-	// cycle through the secrets with shares, where if the share associated with the volID CSI volume mount references
+	// cycle through the secrets with shareConfigMaps, where if the share associated with the volID CSI volume mount references


Suggested change

// cycle through the secrets with shareConfigMaps, where if the share associated with the volID CSI volume mount references

// cycle through the secrets with sharedSecrets, where if the share associated with the volID CSI volume mount references

coreydaley · 2021-09-28T19:47:26Z

pkg/cache/shares.go

+func AddSharedSecret(share *sharev1alpha1.SharedSecret) {
+	br := share.Spec.Secret
+	key := BuildKey(br)
+	klog.V(4).Infof("AddSharedConfigMap key %s", key)


Suggested change

klog.V(4).Infof("AddSharedConfigMap key %s", key)

klog.V(4).Infof("AddSharedSecret key %s", key)

coreydaley · 2021-09-28T19:57:44Z

pkg/controller/controller.go


 	c.informerFactory.Start(stopCh)
-	c.shareInformerFactory.Start(stopCh)
+	c.sharedConfigMapInformerFactory.Start(stopCh)


Maybe I missed it, but I don't see where you are starting the sharedSecretInformerFactory?

yep I missed it - thanks

coreydaley · 2021-09-28T19:58:33Z

pkg/controller/controller.go

 	event := client.Event{
 		Object: s,
 		Verb:   verb,
 	}
-	c.shareWorkqueue.Add(event)
+	c.sharedConfigMapWorkqueue.Add(event)


Suggested change

c.sharedConfigMapWorkqueue.Add(event)

c.sharedSecretWorkqueue.Add(event)

coreydaley · 2021-09-28T19:59:29Z

pkg/controller/controller.go

 	for {
-		obj, shutdown := c.shareWorkqueue.Get()
+		obj, shutdown := c.sharedConfigMapWorkqueue.Get()


Suggested change

obj, shutdown := c.sharedConfigMapWorkqueue.Get()

obj, shutdown := c.sharedSecretMapWorkqueue.Get()

coreydaley · 2021-09-28T19:59:42Z

pkg/controller/controller.go

 		if shutdown {
 			return
 		}

 		func() {
-			defer c.shareWorkqueue.Done(obj)
+			defer c.sharedConfigMapWorkqueue.Done(obj)


Suggested change

defer c.sharedConfigMapWorkqueue.Done(obj)

defer c.sharedSecretWorkqueue.Done(obj)

coreydaley · 2021-09-28T19:59:54Z

pkg/controller/controller.go


 			event, ok := obj.(client.Event)
 			if !ok {
-				c.shareWorkqueue.Forget(obj)
+				c.sharedConfigMapWorkqueue.Forget(obj)


Suggested change

c.sharedConfigMapWorkqueue.Forget(obj)

c.sharedSecretWorkqueue.Forget(obj)

coreydaley · 2021-09-28T20:14:06Z

pkg/hostpath/nodeserver.go

+		sShare, err = client.GetListers().SharedSecrets.Get(secretShareName)
+		if err != nil {
+			return nil, nil, status.Errorf(codes.InvalidArgument,
+				"the csi driver volumeAttribute '%s' reference had an error: %s", secretShareName, err.Error())


Suggested change

"the csi driver volumeAttribute '%s' reference had an error: %s", secretShareName, err.Error())

"the csi driver volumeAttribute %q reference had an error: %s", secretShareName, err.Error())

coreydaley · 2021-09-28T20:14:35Z

pkg/hostpath/nodeserver.go

+	if cmShare != nil {
+		if len(strings.TrimSpace(cmShare.Spec.ConfigMap.Namespace)) == 0 {
+			return nil, nil, status.Errorf(codes.InvalidArgument,
+				"the SharedConfigMap %s backing resource namespace needs to be set", configMapShareName)


Suggested change

"the SharedConfigMap %s backing resource namespace needs to be set", configMapShareName)

"the SharedConfigMap %q backing resource namespace needs to be set", configMapShareName)

coreydaley · 2021-09-28T20:14:58Z

pkg/hostpath/nodeserver.go

+		}
+		if len(strings.TrimSpace(cmShare.Spec.ConfigMap.Name)) == 0 {
+			return nil, nil, status.Errorf(codes.InvalidArgument,
+				"the SharedConfigMap %s backing resource name needs to be set", configMapShareName)


Suggested change

"the SharedConfigMap %s backing resource name needs to be set", configMapShareName)

"the SharedConfigMap %q backing resource name needs to be set", configMapShareName)

coreydaley · 2021-09-28T20:15:11Z

pkg/hostpath/nodeserver.go

+		kind = sharev1alpha1.ResourceReferenceTypeSecret
+		if len(strings.TrimSpace(sShare.Spec.Secret.Namespace)) == 0 {
+			return nil, nil, status.Errorf(codes.InvalidArgument,
+				"the SharedSecret %s backing resource namespace needs to be set", secretShareName)


Suggested change

"the SharedSecret %s backing resource namespace needs to be set", secretShareName)

"the SharedSecret %q backing resource namespace needs to be set", secretShareName)

coreydaley · 2021-09-28T20:15:24Z

pkg/hostpath/nodeserver.go

+		}
+		if len(strings.TrimSpace(sShare.Spec.Secret.Name)) == 0 {
+			return nil, nil, status.Errorf(codes.InvalidArgument,
+				"the SharedSecret %s backing resource name needs to be set", secretShareName)


Suggested change

"the SharedSecret %s backing resource name needs to be set", secretShareName)

"the SharedSecret %q backing resource name needs to be set", secretShareName)

gabemontero · 2021-09-29T15:49:32Z

ok @coreydaley I believe I have addressed the latest set of comments in 2 "core-3" commits (where I squashed the previous review commits

unit tests pass for me locally but I'm still waiting on my cluster to come up to try the e2e's

I'll run those locally when the cluster comes up if I see any failures here in the PR

sbose78 · 2021-09-29T16:06:28Z

Should we update the corresponding enhancement proposal with this change ?

gabemontero · 2021-09-29T16:20:08Z

Should we update the corresponding enhancement proposal with this change ?

yes I'm including that as one of the to-do's for BUILD-353

just getting the code ready first

gabemontero · 2021-09-29T16:20:42Z

aws error with slow

/test e2e-aws-csi-driver-slow

gabemontero · 2021-09-29T16:57:27Z

ok the e2e's are passing for me locally ... would anticipate the slow e2e passing if it gets past unrelated flakes

gabemontero · 2021-09-29T18:53:46Z

and the e2e's are green as well @coreydaley

assuming there is nothing else, and @adambkaplan deferral to us in scrum/office hours today, I'll squash and then we can lgtm / merge

And you can start mapping the api changes back to openshift/api#979

coreydaley

I think these are the last two issues.
If you want to squash your commits and then I think we can get this merged and I can proceed with the openshift/api stuff.

coreydaley · 2021-10-01T12:25:23Z

README.md

 specified in a `Pod` that uses this repository's CSI Driver.
 - separately, any `User` can discover cluster scoped `SharedResources` based on the permissions granted to them by their cluster
 or namespace administrator.

-The full definition of the `SharedResource` custom resource can be found [here](deploy/0000_10_sharedresource.crd.yaml).
+The full definition of the `SharedConfigMap` can be found [here](deploy/0000_10_sharedconfigmap.crd.yaml)or `SharedSecret` custom resource can be found [here](deploy/0000_10_sharedsecret.crd.yaml).


Suggested change

The full definition of the `SharedConfigMap` can be found [here](deploy/0000_10_sharedconfigmap.crd.yaml)or `SharedSecret` custom resource can be found [here](deploy/0000_10_sharedsecret.crd.yaml).

The full definition of the `SharedConfigMap` can be found [here](deploy/0000_10_sharedconfigmap.crd.yaml) or `SharedSecret` custom resource can be found [here](deploy/0000_10_sharedsecret.crd.yaml).

coreydaley · 2021-10-01T12:46:09Z

pkg/controller/controller.go


 	c.informerFactory.Start(stopCh)
-	c.shareInformerFactory.Start(stopCh)
+	c.sharedConfigMapInformerFactory.Start(stopCh)
+	c.sharedConfigMapInformerFactory.Start(stopCh)


Suggested change

c.sharedConfigMapInformerFactory.Start(stopCh)

c.sharedSecretInformerFactory.Start(stopCh)

doc updates update simple example controller updates driver rename add SharedSecret and SharedConfigMap generate-crd e2e tests, including replacing any configmap to secret change tests

gabemontero · 2021-10-01T14:10:30Z

corrections pulled in and pushed, commits squashed @coreydaley thanks !!

coreydaley · 2021-10-01T14:12:21Z

/lgtm

openshift-ci bot assigned adambkaplan and coreydaley Sep 27, 2021

openshift-ci bot requested review from coreydaley and otaviof September 27, 2021 21:46

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2021

gabemontero changed the title ~~name changes, 2 CRDs instead of one for secrets and configmaps~~ BUILD-353: name changes, 2 CRDs instead of one for secrets and configmaps Sep 28, 2021

gabemontero mentioned this pull request Sep 28, 2021

BUILD-353: csi driver, crd name changes openshift/csi-driver-shared-resource-operator#9

Merged

coreydaley reviewed Sep 28, 2021

View reviewed changes

coreydaley requested changes Sep 28, 2021

View reviewed changes

coreydaley reviewed Sep 28, 2021

View reviewed changes

gabemontero force-pushed the chg-type-names-yet-again branch from 196638c to 9b75750 Compare September 28, 2021 19:33

coreydaley requested changes Sep 28, 2021

View reviewed changes

gabemontero force-pushed the chg-type-names-yet-again branch 2 times, most recently from 8ff140a to a8d44b3 Compare September 29, 2021 15:46

sbose78 mentioned this pull request Sep 29, 2021

Insights Operator pulling and exposing data from the OCM API openshift/enhancements#683

Merged

coreydaley requested changes Oct 1, 2021

View reviewed changes

update Makefile

7a51ab2

doc updates update simple example controller updates driver rename add SharedSecret and SharedConfigMap generate-crd e2e tests, including replacing any configmap to secret change tests

gabemontero force-pushed the chg-type-names-yet-again branch from a8d44b3 to 7a51ab2 Compare October 1, 2021 14:09

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2021

openshift-merge-robot merged commit b2fe5d2 into openshift:master Oct 1, 2021

gabemontero deleted the chg-type-names-yet-again branch October 1, 2021 21:18

	- for the `VolumeAttributes` map, this driver currently adds the "share" key (which maps the the `SharedConfigMap` OR `SharedSecret` instance your `Pod` wants to use) in addition to the
	- for the `VolumeAttributes` map, this driver currently adds the "share" key (which maps the `SharedConfigMap` OR `SharedSecret` instance your `Pod` wants to use) in addition to the

	./deploy/0000_10_sharedsecrets.crd.yaml
	./deploy/0000_10_sharedsecret.crd.yaml

		@@ -0,0 +1,22 @@
		# this is the boilerplate crd def that controller-gen reads and modifies with the
		# contents from share_secret_type.go

	# contents from share_secret_type.go
	# contents from shared_secret_type.go

		@@ -0,0 +1,104 @@
		# this is the boilerplate crd def that controller-gen reads and modifies with the
		# contents from share_configmap_type.go

	# contents from share_configmap_type.go
	# contents from shared_configmap_type.go

	// SharedSecret allows a Secret o be shared across namespaces.
	// SharedSecret allows a Secret to be shared across namespaces.

	// within its namespace with an appropriate Role and RoleBinding. For compactness, here are example `oc` invocations for creating
	// within its namespace with an appropriate Role and RoleBinding. For compactness, here are example `oc` invocations for creating

	// secret has not been recognized by the controller; quite possibly timing events on when we learn of shareConfigMaps
	// secret has not been recognized by the controller; quite possibly timing events on when we learn of sharedSecrets

	//NOTE: share update ranger will store share in shareConfigMaps sync.Map
	//NOTE: share update ranger will store share in shareSecrets sync.Map

	shareConfigMapsUpdateCallbacks.Range(buildRanger(buildCallbackMap(share.Name, share)))
	shareSecretsUpdateCallbacks.Range(buildRanger(buildCallbackMap(share.Name, share)))

	// cycle through the secrets with shareConfigMaps, where if the share associated with the volID CSI volume mount references
	// cycle through the secrets with sharedSecrets, where if the share associated with the volID CSI volume mount references

	klog.V(4).Infof("AddSharedConfigMap key %s", key)
	klog.V(4).Infof("AddSharedSecret key %s", key)

	c.sharedConfigMapWorkqueue.Add(event)
	c.sharedSecretWorkqueue.Add(event)

	obj, shutdown := c.sharedConfigMapWorkqueue.Get()
	obj, shutdown := c.sharedSecretMapWorkqueue.Get()

	defer c.sharedConfigMapWorkqueue.Done(obj)
	defer c.sharedSecretWorkqueue.Done(obj)

	c.sharedConfigMapWorkqueue.Forget(obj)
	c.sharedSecretWorkqueue.Forget(obj)

	"the csi driver volumeAttribute '%s' reference had an error: %s", secretShareName, err.Error())
	"the csi driver volumeAttribute %q reference had an error: %s", secretShareName, err.Error())

	"the SharedConfigMap %s backing resource namespace needs to be set", configMapShareName)
	"the SharedConfigMap %q backing resource namespace needs to be set", configMapShareName)

	"the SharedSecret %s backing resource namespace needs to be set", secretShareName)
	"the SharedSecret %q backing resource namespace needs to be set", secretShareName)

BUILD-353: name changes, 2 CRDs instead of one for secrets and configmaps #55

BUILD-353: name changes, 2 CRDs instead of one for secrets and configmaps #55

Conversation

gabemontero commented Sep 27, 2021

openshift-ci bot commented Sep 27, 2021

gabemontero commented Sep 28, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gabemontero commented Sep 28, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gabemontero commented Sep 28, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coreydaley Sep 28, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gabemontero commented Sep 29, 2021

sbose78 commented Sep 29, 2021

gabemontero commented Sep 29, 2021 • edited by openshift-ci bot

gabemontero commented Sep 29, 2021

gabemontero commented Sep 29, 2021

gabemontero commented Sep 29, 2021

coreydaley left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gabemontero commented Oct 1, 2021

coreydaley commented Oct 1, 2021

coreydaley Sep 28, 2021 •

edited

gabemontero commented Sep 29, 2021 •

edited by openshift-ci bot

	The full definition of the `SharedConfigMap` can be found [here](deploy/0000_10_sharedconfigmap.crd.yaml)or `SharedSecret` custom resource can be found [here](deploy/0000_10_sharedsecret.crd.yaml).
	The full definition of the `SharedConfigMap` can be found [here](deploy/0000_10_sharedconfigmap.crd.yaml) or `SharedSecret` custom resource can be found [here](deploy/0000_10_sharedsecret.crd.yaml).

	c.sharedConfigMapInformerFactory.Start(stopCh)
	c.sharedSecretInformerFactory.Start(stopCh)