Bug 2043130: Update CSI sidecars to the latest release for 4.10 #66
Conversation
RecordMetrics() grabs a mutex and calls recordCancelMetric(), which wants to grab the same mutex. Go mutexes are not recursive, so recordCancelMetric blocks forever. recordCancelMetric should not grab the mutex, it can be sure that the caller did it already.
Fix deadlock in recursive metric locks
Update images to v4.2.1
kubernetes-csi/csi-release-tools@5489de6e Merge kubernetes-csi/csi-release-tools#174 from mauriciopoppe/bump-kind-version kubernetes-csi/csi-release-tools@0c675d4c Bump kind version to v0.11.1 kubernetes-csi/csi-release-tools@ef69a88d Merge kubernetes-csi/csi-release-tools#173 from nick5616/add-ws2022 kubernetes-csi/csi-release-tools@44c710c5 added WS2022 to build platforms kubernetes-csi/csi-release-tools@0883be4f Merge kubernetes-csi/csi-release-tools#171 from pohly/example-commands kubernetes-csi/csi-release-tools@02cda510 build.make: support binaries outside of cmd, with optional go.mod kubernetes-csi/csi-release-tools@65922ea2 Merge kubernetes-csi/csi-release-tools#170 from pohly/canary-snapshot-controller kubernetes-csi/csi-release-tools@c0bdfb3a prow.sh: deploy canary snapshot-controller in canary jobs kubernetes-csi/csi-release-tools@0438f15a Merge kubernetes-csi/csi-release-tools#167 from c0va23/feature/release-armv7-image kubernetes-csi/csi-release-tools@4786f4d0 Merge kubernetes-csi/csi-release-tools#168 from msau42/update-release-prereq kubernetes-csi/csi-release-tools@6a2dc64a Remove requirement to be top-level approver. Only maintainers membership is required to do a release kubernetes-csi/csi-release-tools@30a4f7bb Release armv7 image kubernetes-csi/csi-release-tools@ac8108f1 Merge kubernetes-csi/csi-release-tools#165 from consideRatio/pr/update-github-links-ref-to-master-to-HEAD kubernetes-csi/csi-release-tools@999b483d docs: make github links reference HEAD instead of main kubernetes-csi/csi-release-tools@fd670693 docs: make github links reference HEAD instead of master git-subtree-dir: release-tools git-subtree-split: 5489de6
…master master: update release-tools
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
- Also address PR feedback re: avoid a deepCopy for annotations patch Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
…atuserror_patch Use JSON patch for many VolumeSnapshot and VolumeSnapshotContent updates
kubernetes-csi/csi-release-tools@5b9a1e06 Merge kubernetes-csi/csi-release-tools#175 from jimdaga/patch-1 kubernetes-csi/csi-release-tools@5eeb6029 images: use k8s-staging-test-infra/gcb-docker-gcloud git-subtree-dir: release-tools git-subtree-split: 5b9a1e0
master: update release-tools
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
…_status Fix an issue where patch will fail when status is nil
This allows end users to run `kubectl get vs`, for example, instead of `kubectl get volumesnapshot`. The following short names have been implemented: * `VolumeSnapshot` - `vs` * `VolumeSnapshotContent` - `vsc`, `vscs` * `VolumeSnapshotClass` - `vsclass`, `vsclasses` (cherry picked from commit 4f5383a)
…-5.0 Add short names for Volume Snapshot CRDs
Update CertificateSigningRequest apiversion to V1
kubernetes-csi/csi-release-tools@a6a1a797 Merge kubernetes-csi/csi-release-tools#176 from pohly/go-1.17.3 kubernetes-csi/csi-release-tools@0a2cf636 prow.sh: bump Go to 1.17.3 kubernetes-csi/csi-release-tools@fc29fdde Merge kubernetes-csi/csi-release-tools#141 from pohly/prune-replace-optional kubernetes-csi/csi-release-tools@b46691a4 go-get-kubernetes.sh: make replace statement pruning optional git-subtree-dir: release-tools git-subtree-split: a6a1a79
|
@dobsonj: This pull request references Bugzilla bug 2043130, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@dobsonj: This pull request references Bugzilla bug 2043130, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dobsonj: An error was encountered querying GitHub for users with public email (wduan@redhat.com) for bug 2043130 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is from the "Breaking Change" in the release notes for v5.0.1: |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
|
/test ci/prow/e2e-aws-csi |
|
@dobsonj: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-aws-csi |
1 similar comment
|
/test e2e-aws-csi |
|
/test e2e-gcp-csi |
|
@dobsonj: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-csi-snapshot-validation-webhook-container-v4.10.0-202305011254.p0.gfe4a0a2.assembly.stream for distgit csi-snapshot-validation-webhook. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-csi-external-snapshotter-container-v4.10.0-202305011254.p0.gfe4a0a2.assembly.stream for distgit ose-csi-external-snapshotter. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-csi-snapshot-controller-container-v4.10.0-202305011254.p0.gfe4a0a2.assembly.stream for distgit ose-csi-snapshot-controller. |
This rebases on v5.0.1 upstream, bumps the Dockerfiles to the golang 1.17 images, and removes 2 stale Dockerfiles that have not been updated in some time (
Dockerfile.openshift.rhel7andDockerfile.snapshot-controller.openshift).The Dockerfile changes replace the need for these 3 ART PR's, which were blocked until upstream moved to golang 1.17:
Upstream comparison: kubernetes-csi/external-snapshotter@v5.0.1...dobsonj:bug2043130
/cc @openshift/storage