OCPBUGS-13143: Bump gRPC from 1.38.0 to 1.49.0 #41
Conversation
gRPC is under active development, many issues were fixed. The following issue is definitely involved in OCPBUGS-13143: grpc/grpc-go#4632 The regression was caused by grpc/grpc-go#3313 and fixed in 1.40.0 by grpc/grpc-go#4644. It is easy to demonstrate that removing that fix (b1a15ac37 in https://github.com/grpc/grpc-go.git) from this patch re-introduce the issue. So, it is crucial to have at least gRPC 1.40.0 to be immune to that leakage. The patch bumps gRPC to 1.49.0 (rather than tp 1.40.0) firstly because there were other leakages fixed after 1.40.0 (e.g. grpc/grpc-go#5336), and secondly because gRPC 1.49.0 is already used in OCP 4.13, so it must have good coverage.
openshift-ci-robot
added
the
jira/severity-moderate
|
@mpatlasov: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@mpatlasov: This pull request references Jira Issue OCPBUGS-13143, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
|
@mpatlasov: This pull request references Jira Issue OCPBUGS-13143, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@mpatlasov: This pull request references Jira Issue OCPBUGS-13143, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
gRPC is under active development, many issues were fixed. The following issue is definitely involved in OCPBUGS-13143: grpc/grpc-go#4632 The regression was caused by grpc/grpc-go#3313 and fixed in 1.40.0 by grpc/grpc-go#4644. This patch bumps gRPC similarly to 4.10 because gRPC 1.38.0 is vulnerable and 4.11 (before this patch applied) requires gRPC 1.38.0. (See PR for 4.10: openshift#41)
gRPC is under active development, many issues were fixed. The following issue is definitely involved in OCPBUGS-13143: grpc/grpc-go#4632 The regression was caused by grpc/grpc-go#3313 and fixed in 1.40.0 by grpc/grpc-go#4644. This patch bumps gRPC similarly to 4.10 because gRPC 1.38.0 is vulnerable and 4.12 (before this patch applied) requires gRPC 1.38.0. (See PR for 4.10: openshift#41)
|
@mpatlasov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
openshift-ci
bot
added
the
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, mpatlasov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira refresh |
1 similar comment
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@mpatlasov: This pull request references Jira Issue OCPBUGS-13143, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@mpatlasov: Jira Issue OCPBUGS-13143: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-13143 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Fix included in accepted release 4.10.0-0.nightly-2023-06-01-011737 |
gRPC is under active development, many issues were fixed. The following issue is definitely involved in OCPBUGS-13143: grpc/grpc-go#4632 The regression was caused by grpc/grpc-go#3313 and fixed in 1.40.0 by grpc/grpc-go#4644.
It is easy to demonstrate that removing that fix (b1a15ac37 in https://github.com/grpc/grpc-go.git) from this patch re-introduce the issue. So, it is crucial to have at least gRPC 1.40.0 to be immune to that leakage. The patch bumps gRPC to 1.49.0 (rather than to 1.40.0) firstly because there were other leakages fixed after 1.40.0 (e.g. grpc/grpc-go#5336), and secondly because gRPC 1.49.0 is already used in OCP 4.13, so it must have good coverage.