-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-13821: Bump gRPC from 1.38.0 to 1.49.0 #43
OCPBUGS-13821: Bump gRPC from 1.38.0 to 1.49.0 #43
Conversation
gRPC is under active development, many issues were fixed. The following issue is definitely involved in OCPBUGS-13143: grpc/grpc-go#4632 The regression was caused by grpc/grpc-go#3313 and fixed in 1.40.0 by grpc/grpc-go#4644. This patch bumps gRPC similarly to 4.10 because gRPC 1.38.0 is vulnerable and 4.12 (before this patch applied) requires gRPC 1.38.0. (See PR for 4.10: openshift#41)
@mpatlasov: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mpatlasov: This pull request references Jira Issue OCPBUGS-13821, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mpatlasov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/jira refresh |
@mpatlasov: This pull request references Jira Issue OCPBUGS-13821, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@mpatlasov: An error was encountered converting bugzilla URL https://issues.redhat.com/browse/OCPBUGS-12942 to an ID for bug OCPBUGS-13821 on the Jira server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
strconv.Atoi: parsing "https://issues.redhat.com/browse/OCPBUGS-12942": invalid syntax
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@mpatlasov: This pull request references Jira Issue OCPBUGS-13821, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/label backport-risk-assessed |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, mpatlasov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label cherry-pick-approved |
@mpatlasov: Jira Issue OCPBUGS-13821: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-13821 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix included in accepted release 4.12.0-0.nightly-2023-05-23-015255 |
gRPC is under active development, many issues were fixed. The following issue is definitely involved in OCPBUGS-13143: grpc/grpc-go#4632 The regression was caused by grpc/grpc-go#3313 and fixed in 1.40.0 by grpc/grpc-go#4644.
This patch bumps gRPC similarly to 4.10 because gRPC 1.38.0 is vulnerable and 4.12 (before this patch applied) requires gRPC 1.38.0. (See PR for 4.10: #41)