Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-13821: Bump gRPC from 1.38.0 to 1.49.0 #43

Conversation

mpatlasov
Copy link

gRPC is under active development, many issues were fixed. The following issue is definitely involved in OCPBUGS-13143: grpc/grpc-go#4632 The regression was caused by grpc/grpc-go#3313 and fixed in 1.40.0 by grpc/grpc-go#4644.

This patch bumps gRPC similarly to 4.10 because gRPC 1.38.0 is vulnerable and 4.12 (before this patch applied) requires gRPC 1.38.0. (See PR for 4.10: #41)

gRPC is under active development, many issues were fixed. The following issue is definitely involved in OCPBUGS-13143: grpc/grpc-go#4632
The regression was caused by grpc/grpc-go#3313 and fixed in 1.40.0 by grpc/grpc-go#4644.

This patch bumps gRPC similarly to 4.10 because gRPC 1.38.0 is vulnerable and 4.12 (before this patch applied) requires gRPC 1.38.0.
(See PR for 4.10: openshift#41)
@openshift-ci
Copy link

openshift-ci bot commented May 18, 2023

@mpatlasov: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-13821: Bump gRPC from 1.38.0 to 1.49.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 18, 2023
@openshift-ci-robot
Copy link

@mpatlasov: This pull request references Jira Issue OCPBUGS-13821, which is invalid:

  • expected Jira Issue OCPBUGS-13821 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

gRPC is under active development, many issues were fixed. The following issue is definitely involved in OCPBUGS-13143: grpc/grpc-go#4632 The regression was caused by grpc/grpc-go#3313 and fixed in 1.40.0 by grpc/grpc-go#4644.

This patch bumps gRPC similarly to 4.10 because gRPC 1.38.0 is vulnerable and 4.12 (before this patch applied) requires gRPC 1.38.0. (See PR for 4.10: #41)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bertinatto and gnufied May 18, 2023 23:55
@openshift-ci
Copy link

openshift-ci bot commented May 19, 2023

@mpatlasov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mpatlasov
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@mpatlasov: This pull request references Jira Issue OCPBUGS-13821, which is invalid:

  • expected Jira Issue OCPBUGS-13821 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mpatlasov
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@mpatlasov: An error was encountered converting bugzilla URL https://issues.redhat.com/browse/OCPBUGS-12942 to an ID for bug OCPBUGS-13821 on the Jira server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. strconv.Atoi: parsing "https://issues.redhat.com/browse/OCPBUGS-12942": invalid syntax

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mpatlasov
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 22, 2023
@openshift-ci-robot
Copy link

@mpatlasov: This pull request references Jira Issue OCPBUGS-13821, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-13887 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-13887 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link

/lgtm
/approve

@jsafrane
Copy link

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 22, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@duanwei33
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit 9cb0564 into openshift:release-4.12 May 23, 2023
@openshift-ci-robot
Copy link

@mpatlasov: Jira Issue OCPBUGS-13821: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13821 has been moved to the MODIFIED state.

In response to this:

gRPC is under active development, many issues were fixed. The following issue is definitely involved in OCPBUGS-13143: grpc/grpc-go#4632 The regression was caused by grpc/grpc-go#3313 and fixed in 1.40.0 by grpc/grpc-go#4644.

This patch bumps gRPC similarly to 4.10 because gRPC 1.38.0 is vulnerable and 4.12 (before this patch applied) requires gRPC 1.38.0. (See PR for 4.10: #41)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.12.0-0.nightly-2023-05-23-015255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants