Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-26924: Add healthcheck for node-driver-registrar container #155

Merged

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Feb 1, 2024

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 1, 2024
@openshift-ci-robot
Copy link

@gnufied: This pull request references Jira Issue OCPBUGS-26924, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes https://issues.redhat.com/browse/OCPBUGS-26924

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@gnufied
Copy link
Member Author

gnufied commented Feb 1, 2024

/jira refresh

@openshift-ci-robot
Copy link

@gnufied: This pull request references Jira Issue OCPBUGS-26924, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gnufied
Copy link
Member Author

gnufied commented Feb 1, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 1, 2024
@openshift-ci-robot
Copy link

@gnufied: This pull request references Jira Issue OCPBUGS-26924, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Contributor

jsafrane commented Feb 2, 2024

Installation is stuck at:

AzureDiskDriverNodeServiceControllerProgressing: Waiting for DaemonSet to deploy node pods

@gnufied
Copy link
Member Author

gnufied commented Feb 2, 2024

    lastTransitionTime: '2024-02-01T22:11:59Z'
    message: '0/6 nodes are available: 1 node(s) didn''t have free ports for the requested
      pod ports. preemption: 0/6 nodes are available: 1 node(s) didn''t have free
      ports for the requested pod ports, 5 node(s) didn''t match Pod''s node affinity/selector.'
    reason: Unschedulable

@gnufied
Copy link
Member Author

gnufied commented Feb 2, 2024

This is still not good enough and using 10303 will cause conflict with efs-driver.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
Copy link
Contributor

openshift-ci bot commented Feb 3, 2024

@gnufied: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack-csi 005e6d4 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnufied
Copy link
Member Author

gnufied commented Feb 4, 2024

I have changed ports for EFS operator and now - in environments where we have 2 drivers (such ebs and efs), node-registrar-healthcheck will use 10304 and 10305.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2024
@jsafrane
Copy link
Contributor

jsafrane commented Feb 7, 2024

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 57812c5 into openshift:master Feb 7, 2024
14 of 15 checks passed
@openshift-ci-robot
Copy link

@gnufied: Jira Issue OCPBUGS-26924: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-26924 has not been moved to the MODIFIED state.

In response to this:

Fixes https://issues.redhat.com/browse/OCPBUGS-26924

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-disk-csi-driver-operator-container-v4.16.0-202402071412.p0.g57812c5.assembly.stream.el9 for distgit ose-azure-disk-csi-driver-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-04-16-015315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants