Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-26924: Enable healthcheck for node-registrar containerPort #220

Merged

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Feb 1, 2024

This will help from crashing the container if someone runs oc debug accidently against it or something.

Fixes https://issues.redhat.com/browse/OCPBUGS-26924

This will help from crashing the container if someone runs
`oc debug` accidently against it or something.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 1, 2024
@openshift-ci-robot
Copy link
Contributor

@gnufied: This pull request references Jira Issue OCPBUGS-26924, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This will help from crashing the container if someone runs oc debug accidently against it or something.

Fixes https://issues.redhat.com/browse/OCPBUGS-26924

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@jsafrane
Copy link
Contributor

jsafrane commented Feb 2, 2024

/lgtm
/override ci/prow/e2e-vsphere-ovn-upgrade

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024
Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/e2e-vsphere-ovn-upgrade

In response to this:

/lgtm
/override ci/prow/e2e-vsphere-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member Author

gnufied commented Feb 5, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 5, 2024
@openshift-ci-robot
Copy link
Contributor

@gnufied: This pull request references Jira Issue OCPBUGS-26924, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD de3c46e and 2 for PR HEAD 9850e18 in total

@gnufied
Copy link
Member Author

gnufied commented Feb 6, 2024

/override ci/prow/e2e-vsphere-ovn-upgrade

@gnufied
Copy link
Member Author

gnufied commented Feb 6, 2024

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4cd9924 and 1 for PR HEAD 9850e18 in total

@gnufied
Copy link
Member Author

gnufied commented Feb 6, 2024

/override ci/prow/e2e-vsphere-ovn-upgrade

Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

@gnufied: Overrode contexts on behalf of gnufied: ci/prow/e2e-vsphere-ovn-upgrade

In response to this:

/override ci/prow/e2e-vsphere-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor

jsafrane commented Feb 7, 2024

/test e2e-vsphere-csi
/override ci/prow/e2e-vsphere-ovn-upgrade

Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/e2e-vsphere-ovn-upgrade

In response to this:

/test e2e-vsphere-csi
/override ci/prow/e2e-vsphere-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor

jsafrane commented Feb 7, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

@gnufied: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 62baabf into openshift:master Feb 7, 2024
11 checks passed
@openshift-ci-robot
Copy link
Contributor

@gnufied: Jira Issue OCPBUGS-26924: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26924 has been moved to the MODIFIED state.

In response to this:

This will help from crashing the container if someone runs oc debug accidently against it or something.

Fixes https://issues.redhat.com/browse/OCPBUGS-26924

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vmware-vsphere-csi-driver-operator-container-v4.16.0-202402072112.p0.g62baabf.assembly.stream.el9 for distgit ose-vmware-vsphere-csi-driver-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-04-16-015315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants