Merge pull request #240 from vojtechszocs/fix-dep-value-empty-string

Disallow empty string dependency values in DynamicRemotePlugin
openshift · Oct 11, 2023 · bef912f · bef912f
2 parents afe9c16 + 2c1cc81
commit bef912f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/lib-webpack/src/webpack/DynamicRemotePlugin.ts b/packages/lib-webpack/src/webpack/DynamicRemotePlugin.ts
@@ -165,7 +165,8 @@ export class DynamicRemotePlugin implements WebpackPluginInstance {
     const invalidDepNames = Object.entries(
       this.adaptedOptions.pluginMetadata.dependencies ?? {},
     ).reduce<string[]>(
-      (acc, [depName, versionRange]) => (semver.validRange(versionRange) ? acc : [...acc, depName]),
+      (acc, [depName, versionRange]) =>
+        versionRange && semver.validRange(versionRange) ? acc : [...acc, depName],
       [],
     );