New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-3705: Allow transforming plugin manifest at build time #236
CONSOLE-3705: Allow transforming plugin manifest at build time #236
Conversation
@vojtechszocs: This pull request references CONSOLE-3705 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@vojtechszocs: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 41.08% 43.55% +2.46%
==========================================
Files 69 69
Lines 1689 1791 +102
Branches 365 409 +44
==========================================
+ Hits 694 780 +86
- Misses 955 961 +6
- Partials 40 50 +10 ☔ View full report in Codecov by Sentry. |
@@ -157,7 +157,7 @@ export type PluginLoaderOptions = Partial<{ | |||
fetchImpl: ResourceFetch; | |||
fixedPluginDependencyResolutions: Record<string, string>; | |||
sharedScope: AnyObject; | |||
postProcessManifest: (manifest: PluginManifest) => PluginManifest; | |||
transformPluginManifest: TransformPluginManifest; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vojtechszocs looking good! FYI this is used by consoledot - https://github.com/RedHatInsights/insights-chrome/blob/master/src/components/RootApp/ScalprumRoot.tsx#L164
So please be sure to make this a major version bump when publishing.
/lgtm |
@vojtechszocs: This pull request references CONSOLE-3705 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: florkbr, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
add
DynamicRemotePlugin
optiontransformPluginManifest
rename
PluginLoader
optionpostProcessManifest
totransformPluginManifest
for better consistencyrename
DynamicRemotePlugin.moduleFederationSettings
optionsharedScope
tosharedScopeName
refactor internal webpack plugins to accept single options object for better consistency