New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-3705: Phase 1 of using OpenShift Dynamic Plugin SDK #13188
CONSOLE-3705: Phase 1 of using OpenShift Dynamic Plugin SDK #13188
Conversation
@vojtechszocs: This pull request references CONSOLE-3705 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5095576
to
774cedf
Compare
@vojtechszocs: This pull request references CONSOLE-3705 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vojtechszocs: This pull request references CONSOLE-3705 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vojtechszocs: This pull request references CONSOLE-3705 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vojtechszocs: This pull request references CONSOLE-3705 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
774cedf
to
96afc41
Compare
frontend/package.json
Outdated
@@ -11,7 +11,7 @@ | |||
"integration-tests" | |||
], | |||
"scripts": { | |||
"postinstall": "yarn generate", | |||
"postinstall": "# TODO yarn generate", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a temporary change 😃
@@ -100,8 +100,6 @@ a [semver pre-release](https://semver.org/#spec-item-9) identifier, adapt your s | |||
to include the relevant pre-release prefix, e.g. use `~4.11.0-0.ci` when targeting pre-release versions | |||
like `4.11.0-0.ci-1234`. | |||
|
|||
See `ConsolePluginMetadata` type for details on the `consolePlugin` object and its schema. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
@@ -17,12 +17,13 @@ | |||
}, | |||
"devDependencies": { | |||
"@microsoft/tsdoc": "0.14.2", | |||
"@openshift/dynamic-plugin-sdk-webpack": "file:/home/vszocs/work/openshift/dynamic-plugin-sdk/packages/lib-webpack", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using local OpenShift plugin SDK build for now, this will be updated once PR is no longer a draft.
96afc41
to
e2ce6e9
Compare
Tested locally on
|
e2ce6e9
to
20f5650
Compare
20f5650
to
3b20f5a
Compare
@vojtechszocs: This pull request references CONSOLE-3705 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3b20f5a
to
d1c7b90
Compare
/lgtm cancel Looks like the dynamic demo plugin e2e tests are failing. Might be a legit regression. |
4436274
to
b8bb412
Compare
b8bb412
to
7467ca7
Compare
7467ca7
to
dd6de65
Compare
/test e2e-gcp-console |
/retest cluster install failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TheRealJon, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
QE Approver: |
/label docs-approved |
/label px-approved |
@vojtechszocs I checked on cluster launched against the pr, and deployed console-crontab-plugin and console-demo-plugin successfully. If there are other checkpoints need to be covered? |
Hi @yanpzhan - I think the above basic checks should be enough 😃 |
Thanks all. |
@vojtechszocs: This pull request references CONSOLE-3705 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vojtechszocs: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-console-container-v4.15.0-202311301610.p0.g70a927c.assembly.stream for distgit openshift-enterprise-console. |
This PR updates Console dynamic plugin build-time infrastructure to use webpack code from OpenShift Dynamic Plugin SDK.
Console runtime plugin infrastructure is updated to support both current (legacy) and new (standard) plugin manifest formats.
Console plugins built with updated
ConsoleRemotePlugin
will use the standardPluginManifest
format.There are two structural differences between Console legacy vs. standard plugin manifest format:
1. Console specific properties
customProperties
object under theconsole
namespace2. Additional build metadata
Updated
ConsoleRemotePlugin
should be backwards compatible. Its options can be omitted entirely:or specified explicitly as needed:
Env. variable
CONSOLE_PLUGIN_SKIP_EXT_VALIDATOR
is no longer supported byConsoleRemotePlugin
since we already have an explicit option for this purpose (validateExtensionIntegrity
).Other notable changes:
@openshift-console/dynamic-plugin-sdk-webpack
now depends on@openshift/dynamic-plugin-sdk-webpack
5.0.0-beta.16
)cc @spadgett @jhadvig