Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1924985: Build binaries for both RHEL 7 and 8 #33

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

yselkowitz
Copy link
Contributor

egress-router-cni is among those CNI images whose binaries are extracted
from the container onto the node by the cluster-network-operator. Like
the others in this category, its binaries need to be built twice, once
for RHEL 7 and again for RHEL 8, so that they function properly with the
node's userspace, whether it by BYO RHEL 7 or RHCOS.

/assign @dougbtv

egress-router-cni is among those CNI images whose binaries are extracted
from the container onto the node by the cluster-network-operator.  Like
the others in this category, its binaries need to be built twice, once
for RHEL 7 and again for RHEL 8, so that they function properly with the
node's userspace, whether it by BYO RHEL 7 or RHCOS.
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Feb 4, 2021
@openshift-ci-robot
Copy link
Contributor

@yselkowitz: This pull request references Bugzilla bug 1924985, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1924985: Build binaries for both RHEL 7 and 8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 4, 2021
Copy link
Contributor

@danielmellado danielmellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward and consistent with another CNI images such as the whereabouts-cni one. Thanks for bringing this out

@danielmellado
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2021
@tssurya
Copy link
Contributor

tssurya commented Feb 4, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit 96ebd37 into openshift:master Feb 4, 2021
@openshift-ci-robot
Copy link
Contributor

@yselkowitz: All pull requests linked via external trackers have merged:

Bugzilla bug 1924985 has been moved to the MODIFIED state.

In response to this:

Bug 1924985: Build binaries for both RHEL 7 and 8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants