-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1924985: Build binaries for both RHEL 7 and 8 #33
Conversation
egress-router-cni is among those CNI images whose binaries are extracted from the container onto the node by the cluster-network-operator. Like the others in this category, its binaries need to be built twice, once for RHEL 7 and again for RHEL 8, so that they function properly with the node's userspace, whether it by BYO RHEL 7 or RHCOS.
@yselkowitz: This pull request references Bugzilla bug 1924985, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems pretty straightforward and consistent with another CNI images such as the whereabouts-cni one. Thanks for bringing this out
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielmellado, yselkowitz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@yselkowitz: All pull requests linked via external trackers have merged: Bugzilla bug 1924985 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
egress-router-cni is among those CNI images whose binaries are extracted
from the container onto the node by the cluster-network-operator. Like
the others in this category, its binaries need to be built twice, once
for RHEL 7 and again for RHEL 8, so that they function properly with the
node's userspace, whether it by BYO RHEL 7 or RHCOS.
/assign @dougbtv