Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1951158: Protocol needs to be lower case for iptables rules. #46

Merged
merged 2 commits into from
May 21, 2021
Merged

Bug 1951158: Protocol needs to be lower case for iptables rules. #46

merged 2 commits into from
May 21, 2021

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented May 14, 2021 •
edited
Loading

  • API CRD sets protocol as upper case, while iptables expect lower case
  • supported protocols are TCP/UDP and SCTP
  • to-desintaion doesn't need CIDR format
  • update doc

Signed-off-by: Mohamed Mahmoud mmahmoud@redhat.com

@msherif1234
Bug 1951158: protocol needs to be lower case for iptables rules.
f1dc0aa 
API CRD sets protocol as upper case, while iptables expect lower case
supported protocols are TCP/UDP and SCTP

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2021

@msherif1234: This pull request references Bugzilla bug 1951158, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

Bug 1951158: protocol needs to be lower case for iptables rules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 14, 2021
@msherif1234 msherif1234 changed the title Bug 1951158: protocol needs to be lower case for iptables rules. Bug 1951158: Protocol needs to be lower case for iptables rules. May 15, 2021
@alexanderConstantinescu
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@msherif1234
Copy link
Contributor Author

/assign danwinship

@msherif1234
fix IP parsing for desinations and update the doc
d4d5faa 
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 20, 2021

@msherif1234: This pull request references Bugzilla bug 1951158, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

Bug 1951158: Protocol needs to be lower case for iptables rules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 20, 2021

@msherif1234: This pull request references Bugzilla bug 1951158, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

Bug 1951158: Protocol needs to be lower case for iptables rules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knobunc
knobunc approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 699f393 into openshift:master May 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021

@msherif1234: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1951158 has not been moved to the MODIFIED state.

In response to this:

Bug 1951158: Protocol needs to be lower case for iptables rules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced May 28, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc knobunc approved these changes

@alexanderConstantinescu alexanderConstantinescu Awaiting requested review from alexanderConstantinescu

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@danwinship danwinship

@knobunc knobunc

@alexanderConstantinescu alexanderConstantinescu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msherif1234 @alexanderConstantinescu @knobunc @danwinship @openshift-merge-robot