Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-571: Add Indexmanagement cronjobs #215

Merged
merged 1 commit into from
Feb 10, 2020
Merged

LOG-571: Add Indexmanagement cronjobs #215

merged 1 commit into from
Feb 10, 2020

Conversation

jcantrill
Copy link
Contributor

This PR addes indexmanagment cronjobs to satisfy:

https://issues.redhat.com/browse/LOG-571

@jcantrill
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 8, 2020
@jcantrill jcantrill added feature/es6x and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 8, 2020
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 8, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2020
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 9, 2020
@jcantrill jcantrill force-pushed the log571-cron branch 3 times, most recently from 95792be to c6ec91d Compare January 9, 2020 20:18
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 10, 2020
@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

/test e2e-operator

@jcantrill jcantrill force-pushed the log571-cron branch 2 times, most recently from 13e46e3 to 903cce0 Compare January 17, 2020 01:18
@jcantrill
Copy link
Contributor Author

/retest

@jcantrill jcantrill force-pushed the log571-cron branch 2 times, most recently from 12a5ff6 to 1bfa324 Compare January 17, 2020 17:39
@jcantrill
Copy link
Contributor Author

/retest

4 similar comments
@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

/retest

@ewolinetz
Copy link
Contributor

@jcantrill just one comment

@jcantrill
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2020
@mburke5678 mburke5678 mentioned this pull request Feb 7, 2020
Closed
igor-karpukhin
igor-karpukhin approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the nil pointer and error handling comments if it's possible. Apart from that, it looks good.

@jcantrill jcantrill removed the request for review from nhosoi February 7, 2020 18:01
igor-karpukhin
igor-karpukhin approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igor-karpukhin, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [igor-karpukhin,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d73df97 into openshift:feature-es6x Feb 10, 2020
@jcantrill jcantrill deleted the log571-cron branch February 10, 2020 14:18
@mburke5678 mburke5678 mentioned this pull request May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewolinetz ewolinetz ewolinetz left review comments

@igor-karpukhin igor-karpukhin igor-karpukhin approved these changes

Assignees

@igor-karpukhin igor-karpukhin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature/es6x lgtm Indicates that a PR is ready to be merged. release/4.5 size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcantrill @ewolinetz @openshift-ci-robot @igor-karpukhin @openshift-merge-robot