Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrapping Clusters with CAPI Infrastructure Providers #1528

Merged
merged 20 commits into from
May 20, 2024

Conversation

patrickdillon
Copy link
Contributor

This enhancement discusses how openshift-install can use cluster-api (CAPI) providers to provision cluster infrastructure,
without requiring access to an external management cluster or a local container runtime. By running a Kubernetes control plane and CAPI-provider controllers as subprocesses on the installer host, openshift-install can use CAPI and its
providers in a similar manner to how Terraform and its providers are currently being used.

@patrickdillon patrickdillon force-pushed the installer-capi branch 2 times, most recently from f8260c2 to fd47062 Compare December 12, 2023 19:54
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good doc. Lots of questions, still, as is expected for an early draft.

enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
enhancements/installer/cluster-api-based-installations.md Outdated Show resolved Hide resolved
@patrickdillon
Copy link
Contributor Author

@patrickdillon patrickdillon force-pushed the installer-capi branch 2 times, most recently from 187f87d to a502a8c Compare December 15, 2023 18:16
@patrickdillon
Copy link
Contributor Author

Added an Infrastructure Provisioning section. There is pending feedback that I will address after the holidays.

@patrickdillon
Copy link
Contributor Author

@sdodson @2uasimojo @mhrivnak @jnpacker @dtantsur @mdbooth @rvanderp3 @jcpowermac @enxebre @dhellmann @avishaytAll feedback has been addressed and the enhancement updated. PTAL

@zaneb We would like to get this merged. Perhaps we can set a deadline of a week for reviewers to take a look.

@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 16, 2024
@patrickdillon
Copy link
Contributor Author

/remove-lifecycle stale

/assign @zaneb

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 16, 2024
@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 14, 2024
@openshift-bot
Copy link

Stale enhancement proposals rot after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Rotten proposals close after an additional 7d of inactivity.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 21, 2024
@openshift-bot
Copy link

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Apr 29, 2024
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

@openshift-bot: Closed this PR.

In response to this:

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor Author

/reopen

@openshift-ci openshift-ci bot reopened this May 15, 2024
Copy link
Contributor

openshift-ci bot commented May 15, 2024

@patrickdillon: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zaneb
Copy link
Member

zaneb commented May 16, 2024

/approve

Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@sdodson
Copy link
Member

sdodson commented May 20, 2024

/lgtm
/override ci/prow/markdownlint
Going ahead and getting this merged since most of the work has landed and removal of large portions of old implementation is imminent, if there's anything outdated and no longer accurate lets see to it that it gets updated.

Copy link
Contributor

openshift-ci bot commented May 20, 2024

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/markdownlint

In response to this:

/lgtm
/override ci/prow/markdownlint
Going ahead and getting this merged since most of the work has landed and removal of large portions of old implementation is imminent, if there's anything outdated and no longer accurate lets see to it that it gets updated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented May 20, 2024

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c5b9aea into openshift:master May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.