BUILD-353: update with latest CRD,group,csi driver renames #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabemontero
changed the title
|
/assign @adambkaplan |
gabemontero
force-pushed
the
latest-shared-resource-renames
branch
from
66a47e1
to
4ec2c3b
Compare
adambkaplan
approved these changes
Oct 6, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
/assign @coreydaley please provide the double-check @adambkaplan asks .... mostly lines up with your openshift/api work |
coreydaley
suggested changes
Oct 6, 2021
| @@ -164,16 +162,28 @@ An admin creates a new cluster level custom resource for encapsulating the shara | |||
|
|
|||
|
|
|||
| ```yaml | |||
| kind: ShareResource | |||
| apiVersion: storage.openshift.io/v1alpha1 | |||
| kind: ShareConfigMap | |||
There was a problem hiding this comment.
Suggested change
| kind: ShareConfigMap | |
| kind: SharedConfigMap |
| ``` | ||
|
|
||
| ```yaml | ||
| kind: ShareSecret |
There was a problem hiding this comment.
Suggested change
| kind: ShareSecret | |
| kind: SharedSecret |
| resources: | ||
| - shareresources | ||
| - sharedsecrets | ||
| - sharedconfigmaps | ||
| verbs: |
There was a problem hiding this comment.
Should we add watch here also?
gabemontero
force-pushed
the
latest-shared-resource-renames
branch
from
4ec2c3b
to
0155b6b
Compare
|
updates pushed @coreydaley thanks ! |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update on the names or the various CRD/group/driver names for the sharedconfigmap / sharedsecret / sharedresource following the meeting between myself and
@deads2k
@adambkaplan
@bparees
@jsafrane
@coreydaley
on Sep 24 2021
@sbose78 @siamaksade FYI