Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug 1805807: create logic for golang ETCD_INITIAL_CLUSTER #28

Merged
merged 1 commit into from
Feb 21, 2020
Merged

bug 1805807: create logic for golang ETCD_INITIAL_CLUSTER #28

merged 1 commit into from
Feb 21, 2020

Conversation

deads2k
Copy link

@deads2k deads2k commented Feb 20, 2020

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 20, 2020
@retroflexer
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2020
@deads2k deads2k force-pushed the etcd-initial-cluster-02-filecheck branch from 489ba4b to e9cf9b7 Compare February 21, 2020 14:53
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2020
@deads2k deads2k force-pushed the etcd-initial-cluster-02-filecheck branch from e9cf9b7 to 52f6bc9 Compare February 21, 2020 15:02
@deads2k deads2k changed the title create logic for golang ETCD_INITIAL_CLUSTER bug 1805807: create logic for golang ETCD_INITIAL_CLUSTER Feb 21, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 21, 2020
@openshift-ci-robot
Copy link

@deads2k: This pull request references Bugzilla bug 1805807, which is invalid:

  • expected Bugzilla bug 1805807 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

bug 1805807: create logic for golang ETCD_INITIAL_CLUSTER

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hexfusion
hexfusion approved these changes Feb 21, 2020
View reviewed changes
Copy link

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2020
@deads2k deads2k added approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 21, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hexfusion, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion hexfusion mentioned this pull request Feb 21, 2020
Closed
37 tasks
@openshift-merge-robot openshift-merge-robot merged commit 60eed1d into openshift:openshift-4.5 Feb 21, 2020
retroflexer
retroflexer reviewed Feb 24, 2020
View reviewed changes
openshift-tools/pkg/discover-etcd-initial-cluster/initial-cluster.go
// do nothing. This just means we fall through to the polling logic

case err == nil:
fmt.Printf(o.TargetName)
Copy link

@retroflexer retroflexer Feb 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deads2k It looks incorrect. I may be missing something, but since the returned string is assigned to ETCD_INITIAL_CLUSTER, it should be in the form of:
name=url[,name=url]*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retroflexer retroflexer retroflexer left review comments

@hexfusion hexfusion hexfusion approved these changes

@crawford crawford Awaiting requested review from crawford

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@hexfusion hexfusion

@retroflexer retroflexer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deads2k @retroflexer @openshift-ci-robot @hexfusion @openshift-merge-robot