Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1992673: Fix build #93

Merged
merged 3 commits into from Aug 11, 2021
Merged

Conversation

hexfusion
Copy link

@hexfusion hexfusion commented Aug 11, 2021

NOTE: This PR unblocked art builds for etcd.

Our build system uses cachito to provide the vendor dependencies for etcd build but will fail because build.sh which sources scripts/test_lib.sh will attempt to go get gobin. This PR disables that check if readonly is passed to GO_BUILD_FLAGS. In addition we have added a new Dockerfile.art for cachito.

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

@hexfusion: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2021
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion hexfusion changed the title Fix build Bug 1992673: Fix build Aug 11, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 11, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

@hexfusion: This pull request references Bugzilla bug 1992673, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead
  • expected Bugzilla bug 1992673 to depend on a bug targeting a release in 4.10.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1992673: Fix build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Author

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

@hexfusion: This pull request references Bugzilla bug 1992673, which is invalid:

  • expected Bugzilla bug 1992673 to depend on a bug targeting a release in 4.10.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 11, 2021
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Copy link
Author

/retest

@hexfusion hexfusion force-pushed the fix_build branch 2 times, most recently from d9a40aa to a447088 Compare August 11, 2021 21:01
@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

@hexfusion: This pull request references Bugzilla bug 1992673, which is invalid:

  • expected Bugzilla bug 1992673 to depend on a bug targeting a release in 4.10.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

Bug 1992673: Fix build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

….art and update for cachito

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, jupierce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion hexfusion added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2021
@hexfusion
Copy link
Author

hexfusion commented Aug 11, 2021

art approved, self tagging because its blocking image promotion

@hexfusion
Copy link
Author

rebase has CI red this PR unblocks etcd 3.5 promotion into nightly.

/override ci/prow/configmap-scale
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-aws-upgrade

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/configmap-scale, ci/prow/e2e-aws, ci/prow/e2e-aws-serial, ci/prow/e2e-aws-upgrade

In response to this:

rebase has CI red this PR unblocks etcd 3.5 promotion into nightly.

/override ci/prow/configmap-scale
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion merged commit fddc496 into openshift:openshift-4.9 Aug 11, 2021
@hexfusion hexfusion deleted the fix_build branch August 11, 2021 21:22
@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

@hexfusion: All pull requests linked via external trackers have merged:

Bugzilla bug 1992673 has been moved to the MODIFIED state.

In response to this:

Bug 1992673: Fix build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jupierce added a commit to openshift-eng/ocp-build-data that referenced this pull request Aug 11, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

@hexfusion: All pull requests linked via external trackers have merged:

Bugzilla bug 1992673 has been moved to the MODIFIED state.

In response to this:

Bug 1992673: Fix build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link

openshift-ci bot commented Aug 12, 2021

@hexfusion: All pull requests linked via external trackers have merged:

Bugzilla bug 1992673 has been moved to the MODIFIED state.

In response to this:

Bug 1992673: Fix build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants