Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The controller-gen dependency isn't tracked using go modules #245

Closed
rhmdnd opened this issue Jun 30, 2022 · 0 comments
Closed

The controller-gen dependency isn't tracked using go modules #245

rhmdnd opened this issue Jun 30, 2022 · 0 comments
Assignees
@rhmdnd

Comments

@rhmdnd
Copy link
Contributor

rhmdnd commented Jun 30, 2022

From a build perspective, it would be handy to have this dependency tracked using go tooling so that we (as developers, or build systems) don't need to manage it separately.

One possible way to do this is to use tools.go, similar to what the node-observability-operator does.

https://github.com/openshift/node-observability-operator/blob/main/tools/tools.go#L12
@rhmdnd rhmdnd self-assigned this Jun 30, 2022
rhmdnd added a commit to rhmdnd/file-integrity-operator that referenced this issue Jun 30, 2022
@rhmdnd
Add controller-gen to tools.go
068acd7 
Let's track controller-gen as a tool in tools.go instead of managing it
separately.

Fixes openshift#245
This was referenced Jul 1, 2022
Closed
Closed
@openshift-ci openshift-ci bot closed this as completed in e51e9ef Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhmdnd rhmdnd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhmdnd